Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #17678 to use EntityIdFactory instead of depending on the HederaConfig #17879

Open
vtronkov opened this issue Feb 13, 2025 · 0 comments · Fixed by #17922 · May be fixed by #17925
Open

Refactor #17678 to use EntityIdFactory instead of depending on the HederaConfig #17879

vtronkov opened this issue Feb 13, 2025 · 0 comments · Fixed by #17922 · May be fixed by #17925
Assignees
@JivkoKelchev
Milestone
v0.60

Comments

@vtronkov
Copy link
Contributor

vtronkov commented Feb 13, 2025 •
edited
Loading

Our initial implementation of the epic was to get access to HederaConfig and get the shard/realm from there. Michael T. created this story #17822 introducing EntityIdFactory that encasulates the creation of entities with the correct shard/realm.

Get through the changes in #17678 and refactor them to use the new EntityIdFactory objects instead of relying directly on HederaConfig:
@JivkoKelchev JivkoKelchev self-assigned this Feb 14, 2025
@JivkoKelchev JivkoKelchev added this to the v0.60 milestone Feb 14, 2025
@JivkoKelchev JivkoKelchev moved this to 👷🏼‍♀️ In Progress in Services Team Feb 17, 2025
This was linked to pull requests Feb 18, 2025
chore: Use EntityIdFactory #17925
Open
chore: Replace hardcoded shard/realm in test clients #17922
Merged
@JivkoKelchev JivkoKelchev moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Feb 19, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Services Team Feb 19, 2025
@JivkoKelchev JivkoKelchev reopened this Feb 19, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 👷🏼‍♀️ In Progress in Services Team Feb 19, 2025
@JivkoKelchev JivkoKelchev moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JivkoKelchev JivkoKelchev

Labels
None yet
Projects
None yet
Milestone
v0.60
2 participants
@JivkoKelchev @vtronkov