chore: Fix generics use #17884
Merged
chore: Fix generics use #17884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mxtartaglia <[email protected]>
mxtartaglia-sl
requested review from
edward-swirldslabs,
timfn-hg,
abies,
timo0,
IvanKavaldzhiev,
lpetrovic05 and
mustafauzunn
lpetrovic05
previously approved these changes
Feb 13, 2025
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17884 +/- ##
============================================
- Coverage 69.01% 69.01% -0.01%
- Complexity 23050 23055 +5
============================================
Files 2655 2655
Lines 99675 99675
Branches 10289 10289
============================================
- Hits 68795 68790 -5
- Misses 26981 26995 +14
+ Partials 3899 3890 -9
... and 27 files with indirect coverage changes |
timo0
previously approved these changes
Feb 13, 2025
Signed-off-by: mxtartaglia <[email protected]>
mxtartaglia-sl
dismissed stale reviews from timo0 and lpetrovic05
via
bf0cc2b
timfn-hg
approved these changes
Feb 13, 2025
edward-swirldslabs
approved these changes
Feb 13, 2025
...sdk/swirlds-platform-core/src/jmh/java/com/swirlds/platform/core/jmh/ConsensusBenchmark.java
Show resolved
Hide resolved
lpetrovic05
approved these changes
Feb 14, 2025
timo0
approved these changes
Feb 18, 2025
|
spotless failing :-/ |
imalygin
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the use of generics on test classes related to Graphgenerator and EventSource
Fixes #17883