Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-1021: Improve Assignment of Auto-Renew Account ID for Topics #17921

Closed
17 tasks done
netopyr opened this issue Feb 18, 2025 · 0 comments · Fixed by #17938
Closed
17 tasks done

HIP-1021: Improve Assignment of Auto-Renew Account ID for Topics #17921

netopyr opened this issue Feb 18, 2025 · 0 comments · Fixed by #17938
Assignees
Milestone

Comments

@netopyr
Copy link
Contributor

netopyr commented Feb 18, 2025

Background

We want to allow setting the autoRenewAccount when a topic is created even if no adminKey is defined.

Details can be found in HIP-1021.

  • Allow setting autoRenewAccountID even when adminKey is not present on ConsensusTopicCreateHandler
  • Add E2E and unit tests for the change

Test Plan:

Acceptance Criteria

  1. All tests defined in the HIP-1021 testplan pass.

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan here
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
@netopyr netopyr added this to the v0.60 milestone Feb 18, 2025
@netopyr netopyr moved this to Epics in Services Team Feb 18, 2025
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Feb 18, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from Epics to 👷🏼‍♀️ In Progress in Services Team Feb 18, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Feb 18, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from 👀 In Review to 👷🏼‍♀️ In Progress in Services Team Feb 19, 2025
@github-project-automation github-project-automation bot moved this from 👷🏼‍♀️ In Progress to ✅ Done in Services Team Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants