Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HIP-1021 Allow autoRenewAccountID to be set without adminKey on Topics #17938

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

Neeharika-Sompalli
Copy link
Contributor

Fixes #17921

  • Allow autoRenewAccountID to be set without adminKey on Topic creation

Testing:

  • Added unit test
  • Validated with a HapiTest

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
@Neeharika-Sompalli Neeharika-Sompalli requested review from a team as code owners February 18, 2025 19:38
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit d72cab3 into main Feb 19, 2025
46 of 50 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 17931-M-hip-1021 branch February 19, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-1021: Improve Assignment of Auto-Renew Account ID for Topics
5 participants