Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batchKey check in PreHandle Workflow. #17932

Open
15 tasks
iwsimon opened this issue Feb 18, 2025 · 0 comments
Open
15 tasks

Add batchKey check in PreHandle Workflow. #17932

iwsimon opened this issue Feb 18, 2025 · 0 comments

Comments

@iwsimon
Copy link
Contributor

iwsimon commented Feb 18, 2025

Background

If any transaction that is not an inner transaction and has batchKey should fail with BATCH_KEY_SET_ON_NON_INNER_TRANSACTION.

Acceptance Criteria

Add unit and hapi tests.

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
@iwsimon iwsimon self-assigned this Feb 18, 2025
@netopyr netopyr moved this to 👷🏼‍♀️ In Progress in Services Team Feb 19, 2025
@iwsimon iwsimon added this to the v0.60 milestone Feb 19, 2025
@iwsimon iwsimon changed the title Add batchKey check in Ingest Workflow. Add batchKey check in PreHandle Workflow. Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant