Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a Parameter value in __init__ before calling super().__init__ #815

Open
maximlt opened this issue Aug 3, 2023 · 1 comment · May be fixed by #1025
Open

Setting a Parameter value in __init__ before calling super().__init__ #815

maximlt opened this issue Aug 3, 2023 · 1 comment · May be fixed by #1025
Labels
type-bug Bug report
Milestone

Comments

@maximlt
Copy link
Member

maximlt commented Aug 3, 2023

Working on the private namespace I have had to handle when a Parameter value is set in __init__ before calling super().__init__. This is to me an anti-pattern and I would be very happy not having to support that in Param. Also, it sort of works but isn't really fully tested so I wouldn't be surprised if it was also partially broken.

The only occurrence of this patter I found across the HoloViz packages was in HoloViews and it's been updated since then in holoviz/holoviews#5814.

I'd be in favor of deprecating this usage.

@maximlt maximlt added the type-bug Bug report label Aug 3, 2023
@jbednar
Copy link
Member

jbednar commented Aug 16, 2023

I agree with deprecating this usage; it is not something I would expect to be fully supported and it is difficult to imagine a valid need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants