New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HANDS-ON BUG] Invalid Notebook gemma-SFT-thinking-function_call #174

Open

crcdng opened this issue Feb 18, 2025 · 2 comments

Labels

crcdng commented Feb 18, 2025

notebooks/bonus-unit1/gemma-SFT-thinking-function_call.ipynb

is invalid

To Reproduce

link:
https://github.com/huggingface/agents-course/blob/main/notebooks/bonus-unit1/gemma-SFT-thinking-function_call.ipynb

crcdng added the hands-on-bug label

hjqia commented Feb 18, 2025

remove the comma in line 324 to make it a valid json and open the notebook

Contributor

gabyorel commented Feb 18, 2025

Just opened PR #176 to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment