Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not CMake for gns-sys build? #9

Open
debroejm opened this issue Feb 8, 2025 · 0 comments
Open

Why not CMake for gns-sys build? #9

debroejm opened this issue Feb 8, 2025 · 0 comments

Comments

@debroejm
Copy link

debroejm commented Feb 8, 2025

For context, I'm working on a pull request to fix building for Windows, since building gns-sys for Windows is just completely broken. (missing some Windows-specific .c files from upstream, wrong names for libs, etc).

Looking at upstream, GNS uses CMake for its build process. While I haven't delved into trying to use it yet, it appears there is a Rust build dependency for CMake, and I'm curious if there are any reasons that the current cc build dependency is used instead? Manually specifying the build process in build.rs makes it extremely easy to get out of sync, as seen by the above issues with building for Windows. Even worse, upstream already has the appropriate configuration to deal with different platform building, so fixing Windows builds in gns-sys would be duplicating some of that per-platform logic.

tl;dr: Any reason that upstream GNS is compiled with cc in gns-sys, and not CMake? If not, is it alright if I go ahead and make a pull request to switch to CMake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant