From d85523e6b9f775a50736e6d40e4f0c09296562c8 Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Date: Tue, 22 Oct 2024 01:08:23 -0400 Subject: [PATCH 1/5] Update to correct example Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index 6469deaa9b..3b56a7fdfe 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -5486,7 +5486,7 @@ in a block in your network. ```bash ---tx-pool-max-prioritized-by-type= +--tx-pool-max-prioritized-by-type=["TYPE=INTEGER","TYPE=INTEGER"] ``` @@ -5494,7 +5494,7 @@ in a block in your network. ```bash ---tx-pool-max-prioritized-by-type=BLOB=6 +--tx-pool-max-prioritized-by-type=["BLOB=6","FRONTIER=200"] ``` @@ -5502,7 +5502,7 @@ in a block in your network. ```bash -BESU_TX_POOL_MAX_PRIORITIZED_BY_TYPE=BLOB=6 +BESU_TX_POOL_MAX_PRIORITIZED_BY_TYPE=["BLOB=6","FRONTIER=200"] ``` @@ -5510,14 +5510,16 @@ BESU_TX_POOL_MAX_PRIORITIZED_BY_TYPE=BLOB=6 ```bash -tx-pool-max-prioritized-by-type="BLOB=6" +tx-pool-max-prioritized-by-type=["BLOB=6","FRONTIER=200"] ``` -The maximum number of transactions of a specific [transaction type](../../concepts/transactions/types.md) that are prioritized in the [layered transaction pool](../../concepts/transactions/pool.md#layered-transaction-pool). +The maximum number of transactions of a specific [transaction type](../../concepts/transactions/types.md) that are prioritized in the [layered transaction pool](../../concepts/transactions/pool.md#layered-transaction-pool). + +[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, before updates such as [EIP-1559](../../concepts/transactions/types.md##eip1559-transactions). This option is mostly useful for tuning the amount of prioritized [blob transactions](../../concepts/transactions/types.md#blob-transactions) in the transaction pool. Keeping the prioritized layer sorted is costly, and only a few blob transactions can fit in a block (currently a maximum of six). From b5cda3e27bbddc08223686639679c0de346214f5 Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Date: Tue, 22 Oct 2024 10:59:51 -0400 Subject: [PATCH 2/5] update link Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index 3b56a7fdfe..5223ddd0a1 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -5519,7 +5519,7 @@ tx-pool-max-prioritized-by-type=["BLOB=6","FRONTIER=200"] The maximum number of transactions of a specific [transaction type](../../concepts/transactions/types.md) that are prioritized in the [layered transaction pool](../../concepts/transactions/pool.md#layered-transaction-pool). -[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, before updates such as [EIP-1559](../../concepts/transactions/types.md##eip1559-transactions). +[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, before updates such as [EIP-1559](../../concepts/transactions/types.md#eip1559-transactions). This option is mostly useful for tuning the amount of prioritized [blob transactions](../../concepts/transactions/types.md#blob-transactions) in the transaction pool. Keeping the prioritized layer sorted is costly, and only a few blob transactions can fit in a block (currently a maximum of six). From 36c918d69bd801a538426bbb14c5be7db8b2bc1f Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Date: Tue, 22 Oct 2024 12:30:10 -0400 Subject: [PATCH 3/5] add as note? Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index 5223ddd0a1..cbfca0cdd0 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -5519,13 +5519,18 @@ tx-pool-max-prioritized-by-type=["BLOB=6","FRONTIER=200"] The maximum number of transactions of a specific [transaction type](../../concepts/transactions/types.md) that are prioritized in the [layered transaction pool](../../concepts/transactions/pool.md#layered-transaction-pool). -[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, before updates such as [EIP-1559](../../concepts/transactions/types.md#eip1559-transactions). - This option is mostly useful for tuning the amount of prioritized [blob transactions](../../concepts/transactions/types.md#blob-transactions) in the transaction pool. Keeping the prioritized layer sorted is costly, and only a few blob transactions can fit in a block (currently a maximum of six). Tuning the maximum number of prioritized transactions by type can help maintain the efficiency and performance of the transaction pool. The default is `BLOB=6`. +:::note + +[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, +before updates such as [EIP-1559](../../concepts/transactions/types.md#eip1559-transactions). + +::: + ### `tx-pool-max-size` From 8f782a3f7285cab0df72508cf1506ead049b41a8 Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Date: Tue, 22 Oct 2024 13:18:42 -0400 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index cbfca0cdd0..9af3c77f67 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -5486,7 +5486,7 @@ in a block in your network. ```bash ---tx-pool-max-prioritized-by-type=["TYPE=INTEGER","TYPE=INTEGER"] +--tx-pool-max-prioritized-by-type=["",...] ``` From 608cf542ea392ed21f4f21b4f9997ada1fe43494 Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> Date: Tue, 22 Oct 2024 13:19:25 -0400 Subject: [PATCH 5/5] remove noyte Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index 9af3c77f67..4b334c9a69 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -5524,13 +5524,6 @@ Keeping the prioritized layer sorted is costly, and only a few blob transactions Tuning the maximum number of prioritized transactions by type can help maintain the efficiency and performance of the transaction pool. The default is `BLOB=6`. -:::note - -[Frontier is the original Ethereum protocol that introduced the first transaction style with a basic gas fee system, -before updates such as [EIP-1559](../../concepts/transactions/types.md#eip1559-transactions). - -::: - ### `tx-pool-max-size`