Stop command doesn't work for some cover devices #204

iMicknl · 2020-08-05T10:59:33Z

Describe the bug
Currently the cover implementation relies on the available commands of a cover device. However, when a stop command is present, it doesn't mean that the stop command is functional. (thanks Somfy 👍🏻)

ha-tahoma/custom_components/tahoma/cover.py

Lines 217 to 221 in 23eaec1

    
           async def async_stop_cover(self, **_): 
        
               """Stop the cover.""" 
        
               await self.async_execute_command( 
        
                   self.select_command(COMMAND_STOP, COMMAND_STOP_IDENTIFY, COMMAND_MY) 
        
               )

To Reproduce
Steps to reproduce the behavior:

Open or close cover
Press stop button
Cover device doesn't stop moving

Additional context
The integration is not consistent in how it handles a stop command. For example, for the cover_tilt mainly used by Pergolas, we first execute COMMAND_STOP_IDENTIFY since STOP didn't work for my own device...

ha-tahoma/custom_components/tahoma/cover.py

Lines 223 to 227 in 23eaec1

    
           async def async_stop_cover_tilt(self, **_): 
        
               """Stop the cover.""" 
        
               await self.async_execute_command( 
        
                   self.select_command(COMMAND_STOP_IDENTIFY, COMMAND_STOP, COMMAND_MY) 
        
               )

Best would be to:

First use COMMAND_STOP_IDENTIFY or COMMAND_MY to stop a moving cover. This needs to be thoroughly tested to ensure it doesn't cause problems with covers that are not experiencing this issue.

OR

Make sure entities can set their preferred stop method via customize.yaml, as a workaround. I am not a fan of having all those device specific if statements in the integration.

Environment (please complete the following information):

Platform: cover

Device: (if your problem is related to a specific device)

AwningComponent (io:HorizontalAwningIOComponent) (see Add support for AwningComponent (io:HorizontalAwningIOComponent) #59
ExteriorScreen (rts:ExteriorBlindRTSComponent) (see Add support for ExteriorScreen (rts:ExteriorBlindRTSComponent) #43)

The text was updated successfully, but these errors were encountered:

iMicknl · 2020-08-22T10:50:47Z

I found out that stopping the opening of the slats via tahomalink.com doesn't send the stop command for the io:SimpleBioclimaticPergolaIOComponent, but it cancels the execution via the DELETE request...

Even though stop, stopIdentify and my are available, they don't work like they should.

stop doesn't stop the slats moving
stopIdentify does stop the slats moving, however it doesn't stop in a natural way, it moves the slats a few times both sides until it stops. This doesn't look
my doesn't stop the slats moving

{
	"commands": [{
		"commandName": "closeSlats",
		"nparams": 0
	}, {
		"commandName": "delayedStopIdentify",
		"nparams": 1
	}, {
		"commandName": "getName",
		"nparams": 0
	}, {
		"commandName": "identify",
		"nparams": 0
	}, {
		"commandName": "openSlats",
		"nparams": 0
	}, {
		"commandName": "refreshMemorized1Orientation",
		"nparams": 0
	}, {
		"commandName": "setMemorized1Orientation",
		"nparams": 1
	}, {
		"commandName": "setName",
		"nparams": 1
	}, {
		"commandName": "setSecuredOrientation",
		"nparams": 1
	}, {
		"commandName": "setOrientation",
		"nparams": 1
	}, {
		"commandName": "startIdentify",
		"nparams": 0
	}, {
		"commandName": "stop",
		"nparams": 0
	}, {
		"commandName": "stopIdentify",
		"nparams": 0
	}, {
		"commandName": "wink",
		"nparams": 1
	}, {
		"commandName": "pairOneWayController",
		"nparams": 2
	}, {
		"commandName": "unpairAllOneWayControllers",
		"nparams": 0
	}, {
		"commandName": "unpairOneWayController",
		"nparams": 2
	}],
	"states": [{
		"values": ["good", "low", "normal", "verylow"],
		"type": "DiscreteState",
		"qualifiedName": "core:DiscreteRSSILevelState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "core:Memorized1OrientationState"
	}, {
		"type": "DataState",
		"qualifiedName": "core:NameState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "core:PriorityLockTimerState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "core:RSSILevelState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "core:SecuredOrientationState"
	}, {
		"values": ["closed", "open"],
		"type": "DiscreteState",
		"qualifiedName": "core:SlatsOpenClosedState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "core:SlatsOrientationState"
	}, {
		"values": ["available", "unavailable"],
		"type": "DiscreteState",
		"qualifiedName": "core:StatusState"
	}, {
		"values": ["comfortLevel1", "comfortLevel2", "comfortLevel3", "comfortLevel4", "environmentProtection", "humanProtection", "userLevel1", "userLevel2"],
		"type": "DiscreteState",
		"qualifiedName": "io:PriorityLockLevelState"
	}, {
		"values": ["LSC", "SAAC", "SFC", "UPS", "externalGateway", "localUser", "myself", "rain", "security", "temperature", "timer", "user", "wind"],
		"type": "DiscreteState",
		"qualifiedName": "io:PriorityLockOriginatorState"
	}],
	"dataProperties": [{
		"value": "500",
		"qualifiedName": "core:identifyInterval"
	}],
	"widgetName": "BioclimaticPergola",
	"uiClass": "Pergola",
	"qualifiedName": "io:SimpleBioclimaticPergolaIOComponent",
	"type": "ACTUATOR"
}

Glenn1986 · 2020-09-01T07:33:50Z

@iMicknl can I help with testing for this problem. I have RTS roller shutters and the stop command doesn't work?

iMicknl · 2020-09-01T08:18:34Z

@Glenn1986 are you familiar with Developer Tools in your browser? Could you capture which XHR requests happen when you open the cover and cancel the command?

Glenn1986 · 2020-09-01T08:57:58Z

Oke I will try, do you mean the xhr request in home assistant or in tahomalink? I think the last one but want to be sure ;)

vlebourl · 2020-09-01T08:58:51Z

yes tahomalink!

Glenn1986 · 2020-09-02T05:42:41Z

Hope this information helps you guys
{execution: {eventTime: 1599025157127, owner: "xxxxxx", source: "mobile:mobile",…}}
execution: {eventTime: 1599025157127, owner: "xxxx", source: "mobile:mobile",…}
commands: [,…]
0: {deviceURL: "xxxx", command: "close", parameters: [], rank: 0, dynamic: false,…}
command: "close"
deviceURL: "xxxx"
dynamic: false
failureType: "CMDCANCELLED"
parameters: []
rank: 0
state: "FAILED"
duration: 7825
effectiveStartTime: 1599025157127
endTime: 1599025164952
eventTime: 1599025157127
executionSubType: "MANUAL_CONTROL"
executionType: "Immediate execution"
failureType: "CMDCANCELLED"
id: "xxxx"
label: "Slaapkamer 3.1 - Sluiten - TaHoma PC"
owner: "xxxx"
source: "mobile:mobile"
state: "FAILED"
type: "Immediate execution - MANUAL_CONTROL"

iMicknl · 2020-09-02T07:34:40Z

Thanks @Glenn1986. Could you have a look if the previous request is a DELETE request? I will start working on it this weekend probably, so will soon have a version to test.

Glenn1986 · 2020-09-02T10:03:52Z

Request URL: https://www.tahomalink.com/enduser-mobile-web/enduserAPI/exec/current/setup/4e440f95-ac10-3e01-2775-8dbb10e9de74
Request Method: DELETE
Status Code: 204
Remote Address: xxxx
Referrer Policy: no-referrer-when-downgrade

It's indeed a delete request before above information is received. :)

iMicknl · 2020-09-02T11:08:52Z

Great to hear! I have implemented a first try in https://github.com/iMicknl/ha-tahoma/tree/enhancement/improve_stop_functionality, could you give it a try?

You can download this zip https://github.com/iMicknl/ha-tahoma/archive/enhancement/improve_stop_functionality.zip and extract the tahoma folder to your custom_components folder. Please delete the old one first to make sure you don't have any left overs. Please turn on debug logging to catch the errors and logging :).

Glenn1986 · 2020-09-03T10:48:56Z

Hi @iMicknl. I did the test with the new version you made but didn't work. Gives me the error: Kan service cover/stop_cover niet aanroepen 'TahomaCover' object has no attribute 'debug'.

iMicknl · 2020-09-03T10:51:45Z

@Glenn1986 oops, I made an obvious mistake. It is fixed in the latest version.
I can try this myself this Sunday the earliest unfortunately.

Glenn1986 · 2020-09-03T11:02:47Z

Ok let me know if i can help further with testing. 😊

iMicknl · 2020-09-03T11:38:19Z

@Glenn1986 you could download the zip again and retry :)

Glenn1986 · 2020-09-03T14:18:20Z

@iMicknl i tested again and now it worked. The rollershutter stopped but he gives on error: Kan service cover/stop_cover niet aanroepen 'NoneType' object has no attribute 'get'.

iMicknl · 2020-09-03T14:58:22Z

Cool! I will have a look myself and polish it up a bit, but great to know that the stop functionality is finally working for you.

iMicknl · 2020-09-04T13:19:01Z

@Glenn1986 if you could try the latest version and report if this solved your issues, would be appreciated 👍🏻

Glenn1986 · 2020-09-05T07:52:33Z

@iMicknl i just tested your new version. Everything worked well and no errors showing up. Nice work!

Glenn1986 · 2020-09-06T08:33:32Z

@iMicknl in which release will you're fix for stop command cover released?

iMicknl · 2020-09-06T11:05:29Z

@Glenn1986 it depends a little bit on the code review, I expect it to go out with a release in the next week. I will close this issue once it is merged to master, so you will get a notification :-).

Glenn1986 · 2020-09-06T12:22:50Z

Thanks!

golles · 2020-09-14T20:24:37Z

I was about to report this bug, as I noticed it today, now I see a fix has been merged 12 hours ago. It works for my RTS awning, well done!!

iMicknl · 2020-09-14T20:46:39Z

@golles thanks for first looking at closed issues / pr's 😄! This PR took a bit longer to get merged, but I will do a new release soon with some more fixes.

For now, you could install the latest master via HACS or manually.

golles · 2020-09-14T21:12:18Z

Great to hear that you're so active! I bought the Tahoma box recently and I'm really happy to see that you and the others rewrite this component.
I manually pull the master branch into my custom_components, I try to update all my dependencies a couple of times per week :-)
Looking forward to what's coming!

iMicknl added bug Something isn't working platform: cover labels Aug 5, 2020

This was referenced Aug 5, 2020

Add support for AwningComponent (io:HorizontalAwningIOComponent) #59

Closed

Add support for ExteriorScreen (rts:ExteriorBlindRTSComponent) #43

Closed

iMicknl mentioned this issue Aug 12, 2020

Expose my position for covers via a service #220

Closed

iMicknl mentioned this issue Aug 22, 2020

Sliding gate not working #234

Closed

iMicknl linked a pull request Sep 2, 2020 that will close this issue

Improve stop and stop tilt command for covers #251

Merged

iMicknl closed this as completed in #251 Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop command doesn't work for some cover devices #204

Stop command doesn't work for some cover devices #204

iMicknl commented Aug 5, 2020 •

edited

Loading

iMicknl commented Aug 22, 2020 •

edited

Loading

Glenn1986 commented Sep 1, 2020

iMicknl commented Sep 1, 2020

Glenn1986 commented Sep 1, 2020

vlebourl commented Sep 1, 2020

Glenn1986 commented Sep 2, 2020 •

edited

Loading

iMicknl commented Sep 2, 2020

Glenn1986 commented Sep 2, 2020

iMicknl commented Sep 2, 2020 •

edited

Loading

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

iMicknl commented Sep 4, 2020

Glenn1986 commented Sep 5, 2020

Glenn1986 commented Sep 6, 2020

iMicknl commented Sep 6, 2020

Glenn1986 commented Sep 6, 2020

golles commented Sep 14, 2020

iMicknl commented Sep 14, 2020

golles commented Sep 14, 2020

Stop command doesn't work for some cover devices #204

Stop command doesn't work for some cover devices #204

Comments

iMicknl commented Aug 5, 2020 • edited Loading

iMicknl commented Aug 22, 2020 • edited Loading

Glenn1986 commented Sep 1, 2020

iMicknl commented Sep 1, 2020

Glenn1986 commented Sep 1, 2020

vlebourl commented Sep 1, 2020

Glenn1986 commented Sep 2, 2020 • edited Loading

iMicknl commented Sep 2, 2020

Glenn1986 commented Sep 2, 2020

iMicknl commented Sep 2, 2020 • edited Loading

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

Glenn1986 commented Sep 3, 2020

iMicknl commented Sep 3, 2020

iMicknl commented Sep 4, 2020

Glenn1986 commented Sep 5, 2020

Glenn1986 commented Sep 6, 2020

iMicknl commented Sep 6, 2020

Glenn1986 commented Sep 6, 2020

golles commented Sep 14, 2020

iMicknl commented Sep 14, 2020

golles commented Sep 14, 2020

iMicknl commented Aug 5, 2020 •

edited

Loading

iMicknl commented Aug 22, 2020 •

edited

Loading

Glenn1986 commented Sep 2, 2020 •

edited

Loading

iMicknl commented Sep 2, 2020 •

edited

Loading