Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom command feature missing in 0.13 #2543

Closed
4 tasks done
Decodetalkers opened this issue Aug 7, 2024 · 5 comments
Closed
4 tasks done

custom command feature missing in 0.13 #2543

Decodetalkers opened this issue Aug 7, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Decodetalkers
Copy link
Contributor

Is your issue REALLY a bug?

  • My issue is indeed a bug!
  • I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

In month, I make a pr in #2146. This pr allow to add extra action passed to iced, it is merged, and we develop https://github.com/waycrate/exwlshelleventloop this project. but now I find this feature is missing in new iced..

What is the expected behavior?

Can you help keep the feature? it is important to our program

Version

master

Operating System

macOS

Do you have any log output?

No response

@Decodetalkers Decodetalkers added the bug Something isn't working label Aug 7, 2024
@Decodetalkers
Copy link
Contributor Author

I find the structure of iced is changed, not it cannot simply add a Box into actions..

@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Aug 7, 2024

Ok.. maybe I can use Action::Output<T>, and Strict T to have try_into() trait.. can be try_into my custom actions

the breaking change in 0.13 is too much.. I am afraid I cannot follow the changes

@Decodetalkers Decodetalkers changed the title feature missing custom command feature missing in 0.13 Aug 7, 2024
@jdbosser
Copy link

jdbosser commented Aug 9, 2024

Regarding the breaking changes: I think this is to be expected with software that is still in active development. The maintainers of iced have warned us at several instances that breaking changes are likely.

I, for one, do want breaking changes at this moment in time, since this allows the maintainers to experiment and to find an api that makes sense. It is better for the project in the long run.

To help you out, while I have no experience working with Commands, I think that the struct you are looking for is now located at iced::Task.

@DaRacci
Copy link

DaRacci commented Oct 8, 2024

It would be a good idea to start including breaking changes in the change-logs like renaming of Command to Task.

@Decodetalkers
Copy link
Contributor Author

Ok , this is not a problem for me anymore.. ok, I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants