Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deduplicate parameter to create topic using CLI (Preferred) #4388

Open
fraidev opened this issue Feb 11, 2025 · 2 comments
Open

add deduplicate parameter to create topic using CLI (Preferred) #4388

fraidev opened this issue Feb 11, 2025 · 2 comments
Assignees

Comments

@fraidev
Copy link
Contributor

fraidev commented Feb 11, 2025

New options:

fluvio topic create dedup_topic --dedup
fluvio topic create dedup_topic --dedup --dedup-age 1h --dedup-count 5 

When there is no fluvio/[email protected] smartmodule downloaded and loaded:

fluvio topic create dedup_topic --dedup
deduplication filter not found, downloading
Using org access: fluvio
Using hub https://hub.infinyon.cloud
downloading fluvio/[email protected] to fluvio-dedup-bloom-filter-0.1.0.ipkg
... downloading complete
... checking package
... cluster smartmodule install complete
topic "dedup_topic" created

When there is fluvio/[email protected] smartmodule downloaded and loaded:

fluvio topic create dedup_topic --dedup
topic "dedup_topic" created
@ajhunyady
Copy link
Contributor

ajhunyady commented Feb 11, 2025

Is this preferred or advanced? It seems to be the same thing again.
Let's not mix please.

@fraidev
Copy link
Contributor Author

fraidev commented Feb 11, 2025

Is this preferred or advanced? It seems to be the same thing again.
Let's not mix please.

Preferred. Do you mean about the download part, right? Yeah, I forgot it. By the way, should we add remote parameter for the hub here too? Or only use the remote from config?

@ajhunyady ajhunyady changed the title add deduplicate parameter to create topic using CLI add deduplicate parameter to create topic using CLI (Preferred) Feb 11, 2025
@fraidev fraidev self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants