-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No token renewal on OS update #29
Comments
This would require adding a new permission (RECEIVE_BOOT_COMPLETED) - which I would like to avoid. I think we could do this as an optional feature of the library - you would specify the permission in your application manifest and the library would then handle it. I will have to think about this. Or maybe if someone can submit a pull request. |
@DanielNovak do you have any news about this? If you want a PR, what would be some code design guidelines you'd have in mind? |
@adrien-aubel Sorry - no news yet, but I have it in my backlog. I haven't thought about it in detail yet - so now specific code guidelines :-(. I can't promise an ETA, but I would like to at least start this weekend on this. |
Ping @DanielNovak :) |
@adrien-aubel do not worry about code guidelines, regular Android style is fine. Just make a PR, that's where we can discuss :-) |
This could be fixed in version 1.5.0 as we started using Probably needs testing, before we can close this issue |
When Android is upgraded, Google offers no guarantee the GCM token will keep working, and we saw some cases where GCM would stop working after an upgrade to Android 5.1.
EasyGCM should probably listen to system boot and renew the GCM token if needed:
Waiting a few seconds for the network to be available, or even better, some exponential backoff, could be a good idea.
The text was updated successfully, but these errors were encountered: