Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting it to work not as simple as expected, or documentation issue? #66

Open
polaski opened this issue Dec 19, 2015 · 1 comment
Open

Comments

@polaski
Copy link

polaski commented Dec 19, 2015

Maybe it's just me, but I had to try all kinds of things to get this to work properly. First of all, the init command in the README file didn't even work. I already made one pull request that updated the init command.

Also, even before reaching this point I had to spend some time figuring out how to get it to build correctly. More specifically, I had to:

  1. add classpath 'com.google.gms:google-services:1.5.0-beta2' to root gradle file
  2. add apply plugin: 'com.google.gms.google-services' to module gradle file, and compile 'com.google.android.gms:play-services-gcm:8.3.0' under dependencies.

Are these simply not documented on README, or did I miss something?

@Epholl
Copy link
Contributor

Epholl commented Dec 21, 2015

Hello @polaski ,
I have checked your pull request and the comments. The missing classpath, plugin and dependency are not in the readme, has to and will be fixed.
However, from the way you suggest using EasyGcm.setGcmListener(this) instead of EasyGcm.init(Context context) in your pull request, it seems you might be implementing the GcmListener in a different place than the readme suggests. The EasyGcm.setGcmListener(GcmListener listener) needs you to pass an object implementing the interface whereas EasyGcm.init(Context context) requires you to implement the GcmListener in your Application class. What is the structure of the application you are using easygcm with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants