Workflow to test Triton with nightly PyTorch wheels on Windows #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
reviewed
Jan 18, 2025
| - name: Run core tests | ||
| run: | | ||
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | ||
| ${{ env.NEW_WORKSPACE }}\venv\Scripts\activate.ps1 |
There was a problem hiding this comment.
Judging by the logs, the tests are run with the python that is installed on the system (instead of the virtual environment). Perhaps we need to activate the environment inside of scripts/test-triton.sh?
There was a problem hiding this comment.
Yep, working on it. In worst case, I will rewrite (parts of) test-triton.sh in Python.
anmyachev
reviewed
Jan 18, 2025
Comment on lines
103
to
109
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | ||
| ${{ env.TRITON_TEST_CMD }} --core | ||
|
|
||
| - name: Run interpreter tests | ||
| run: | | ||
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | ||
| ${{ env.TRITON_TEST_CMD }} --interpreter |
There was a problem hiding this comment.
cd ${{ env.NEW_WORKSPACE }} ?
Suggested change
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | |
| ${{ env.TRITON_TEST_CMD }} --core | |
| - name: Run interpreter tests | |
| run: | | |
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | |
| ${{ env.TRITON_TEST_CMD }} --interpreter | |
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | |
| cd ${{ env.NEW_WORKSPACE }} | |
| ${{ env.TRITON_TEST_CMD }} --core | |
| - name: Run interpreter tests | |
| run: | | |
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | |
| cd ${{ env.NEW_WORKSPACE }} | |
| ${{ env.TRITON_TEST_CMD }} --interpreter |
There was a problem hiding this comment.
As you build triton in new workspace:
- name: Setup Triton
run: |
Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
.venv\Scripts\activate.ps1
cd ${{ env.NEW_WORKSPACE }}There was a problem hiding this comment.
The "new workspace" is required only to build Triton (since cl.exe does not support long names). Everything else works from the standard workspace.
anmyachev
reviewed
Jan 18, 2025
| run: | | ||
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 | ||
| ${{ env.NEW_WORKSPACE }}\venv\Scripts\activate.ps1 | ||
| pip install defusedxml |
There was a problem hiding this comment.
Suggested change
| pip install defusedxml | |
| cd ${{ env.NEW_WORKSPACE }} | |
| pip install defusedxml |
There was a problem hiding this comment.
Not needed, the standard workspace works.
On Windows, this points to Python that is not from venv.
anmyachev
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177.