Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for identical Fulfillment.serializeBase64Url and .serializeUri? #69

Open
sbellem opened this issue Jun 8, 2017 · 0 comments
Open

Comments

@sbellem
Copy link
Contributor

sbellem commented Jun 8, 2017

The two functions are identical:

/**
 * Base class for fulfillment types.
 */
class Fulfillment {

  serializeUri () {
    return base64url.encode(this.serializeBinary())
  }

  serializeBase64Url () {
    return base64url.encode(this.serializeBinary())
  }

Is one preferred over the other moving forward?

@sbellem sbellem changed the title Reason for identical Fulfillment.serializeBase64Url and .serializeUri Reason for identical Fulfillment.serializeBase64Url and .serializeUri? Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant