Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy extensions from incoming packet to outgoing packet #405

Open
michielbdejong opened this issue Jan 18, 2018 · 3 comments
Open

copy extensions from incoming packet to outgoing packet #405

michielbdejong opened this issue Jan 18, 2018 · 3 comments

Comments

@michielbdejong
Copy link
Contributor

No description provided.

@emschwartz
Copy link
Member

For context: one of the arguments for having a specific packet encoding was to make it easier to extend ILP later, because intermediaries would pass on extensions they don't understand. However, the ilp-connector isn't actually doing that right now so we should set the example if we want extensions to have a hope of working in the future.

@michielbdejong
Copy link
Contributor Author

Note that, actually, the newer packet types have no extensions, but rely on the envelope length indicator instead.

So ilp-packet should accept something like a 'trailingBytes' field (defaulting to 0 bytes) when serializing, and also return that field when deserializing, and then ilp-connector should take that buffer from the incoming transfer and if non-empty, slap it onto the end of the outgoing transfer.

@sharafian
Copy link

👍 Editing in place may also be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants