Skip to content

Commit

Permalink
fix(tests): use two different timeouts
Browse files Browse the repository at this point in the history
  • Loading branch information
nqb committed Dec 13, 2022
1 parent 9dee893 commit 5f17c7c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
30 changes: 15 additions & 15 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ stages:
################################################################################
variables:
# synced with Pipeline timeout in GitLab UI
PIPELINE_TIMEOUT: 170m
PIPELINE_TIMEOUT_SCRIPT: 160m
PIPELINE_TIMEOUT_AFTER_SCRIPT: 10m
BUILD_PFAPPSERVER_VUE: "yes"
PFBUILD_CENTOS_8_IMG: ghcr.io/inverse-inc/packetfence/pfbuild-centos-8
PFBUILD_DEB_BULLSEYE_IMG: ghcr.io/inverse-inc/packetfence/pfbuild-debian-bullseye
Expand Down Expand Up @@ -274,7 +275,7 @@ variables:
.build_img_docker_job:
stage: build_img
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${PACKERDIR} build_img_docker_pfbuild
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${PACKERDIR} build_img_docker_pfbuild
tags:
- shell

Expand Down Expand Up @@ -322,9 +323,9 @@ variables:
RESULT_DIR: /var/local/gitlab-runner/vagrant_img
BOX_DESC: ${CI_PIPELINE_URL}
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${VAGRANT_IMG_DIR} ${BOX_NAME}
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${VAGRANT_IMG_DIR} ${BOX_NAME}
after_script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${VAGRANT_IMG_DIR} clean
- timeout ${PIPELINE_TIMEOUT_AFTER_SCRIPT} make -e -C ${VAGRANT_IMG_DIR} clean
tags:
- shell
- inverse.ca
Expand Down Expand Up @@ -493,8 +494,7 @@ variables:
name: sourceforge
url: ${SF_ZEN_REPO_URL}/${CI_COMMIT_REF_NAME}
after_script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ZENDIR} clean
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ZENDIR} clean_cache
- timeout ${PIPELINE_TIMEOUT_AFTER_SCRIPT} make -e -C ${ZENDIR} clean_all
dependencies: []
tags:
- shell
Expand All @@ -504,7 +504,7 @@ variables:
environment:
name: sourceforge
after_script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ISODIR} clean
- timeout ${PIPELINE_TIMEOUT_AFTER_SCRIPT} make -e -C ${ISODIR} clean
dependencies: []
tags:
- shell
Expand All @@ -515,9 +515,9 @@ variables:
RESULT_DIR: /var/local/gitlab-runner/vagrant_img
BOX_DESC: ${CI_PIPELINE_URL}
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${VAGRANT_IMG_DIR} ${BOX_NAME}
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${VAGRANT_IMG_DIR} ${BOX_NAME}
after_script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${VAGRANT_IMG_DIR} clean
- timeout ${PIPELINE_TIMEOUT_AFTER_SCRIPT} make -e -C ${VAGRANT_IMG_DIR} clean
dependencies: []
tags:
- inverse.ca
Expand All @@ -535,9 +535,9 @@ variables:
variables:
VAGRANT_COMMON_DOTFILE_PATH: /var/local/gitlab-runner/vagrant/vagrant-common-${CI_COMMIT_REF_SLUG}
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${TESTDIR} MAKE_TARGET=run ${CI_JOB_NAME}
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${TESTDIR} MAKE_TARGET=run ${CI_JOB_NAME}
after_script:
- timeout ${PIPELINE_TIMEOUT} ${TESTCIDIR}/clean-test-environment.sh
- timeout ${PIPELINE_TIMEOUT_AFTER_SCRIPT} ${TESTCIDIR}/clean-test-environment.sh

################################################################################
# JOBS
Expand Down Expand Up @@ -1475,13 +1475,13 @@ build_pf_img_zen_devel_branches_and_maintenance:
- .build_pf_img_zen_job
- .build_pf_img_zen_devel_branches_and_maintenance_rules
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ZENDIR} zen-deb11
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${ZENDIR} zen-deb11

build_pf_img_zen_release:
extends:
- .build_pf_img_zen_job
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ZENDIR} zen-deb11
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${ZENDIR} zen-deb11
# workaround for https://forum.gitlab.com/t/specify-when-at-job-level-with-a-job-that-has-rules/4769
rules:
- if: '$CI_COMMIT_TAG'
Expand All @@ -1496,7 +1496,7 @@ build_pf_img_iso_devel_branches_and_maintenance:
environment:
url: ${SF_ISO_REPO_URL}/${CI_COMMIT_REF_SLUG}
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ISODIR} iso
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${ISODIR} iso

build_pf_img_iso_release:
extends:
Expand All @@ -1506,7 +1506,7 @@ build_pf_img_iso_release:
environment:
url: ${SF_ISO_REPO_URL}/${CI_COMMIT_TAG}
script:
- timeout ${PIPELINE_TIMEOUT} make -e -C ${ISODIR} iso
- timeout ${PIPELINE_TIMEOUT_SCRIPT} make -e -C ${ISODIR} iso
# workaround for https://forum.gitlab.com/t/specify-when-at-job-level-with-a-job-that-has-rules/4769
rules:
- if: '$CI_COMMIT_TAG'
Expand Down
3 changes: 3 additions & 0 deletions ci/packer/zen/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ zen:
VM_NAME=$(VM_NAME) \
./build-and-upload.sh

.PHONY: clean_all
clean_all: clean clean_cache

.PHONY: clean
clean:
rm -rf $(RESULT_DIR)
Expand Down

0 comments on commit 5f17c7c

Please sign in to comment.