Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Flutterfire CLI ignores provided platforms #333

Closed
1 task done
avdept opened this issue Aug 6, 2024 · 2 comments
Closed
1 task done

[bug]: Flutterfire CLI ignores provided platforms #333

avdept opened this issue Aug 6, 2024 · 2 comments
Labels
bug Something isn't working keep open Needs Attention OP created or responded to issue and it needs attention. triage

Comments

@avdept
Copy link

avdept commented Aug 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

CLI Version

1.0.0

Firebase Tools version

13.15.0

Flutter Doctor Output

[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale en-US)
    • Flutter version 3.22.3 on channel stable at /opt/homebrew/Caskroom/flutter/3.22.3/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0850beeb2 (3 weeks ago), 2024-07-16 21:43:41 -0700
    • Engine revision 235db911ba
    • Dart version 3.4.4
    • DevTools version 2.34.3

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed
      instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.


[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed
      instructions).

[✓] VS Code (version 1.91.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (4 available)
    • UDF (2) (mobile)                • 00008120-00146DD23E83C01E • ios            • iOS 17.5.1 21F90
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.5 23F79
      darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.5 23F79
      darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome
      127.0.6533.89

Description

flutterfire configure --yes --project=#{build_configuration['PROJECT_ID']} --ios-bundle-id=com.my.app --platforms=ios --token="REMOVED"

Steps to reproduce

  1. Run command
  2. See cli asking for android, macOS, windows build IDs

Expected behavior

If I pass only ios platform I expect only config for iOS to be queries and command succeeds(creates/updates config)

Screenshots

No response

Additional context and comments

Im building fastlane lane for deploying only iOS apps. I don't even have android app created on firebase project. However flutterfire asks me to provide bundleID for every platform. I expected that passing --platforms flag to limit config only to provided values

@avdept avdept added bug Something isn't working triage labels Aug 6, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@russellwheatley
Copy link
Member

I cannot reproduce this. Here is output from console:

➜  whodunnit flutterfire configure --project=dewqqqqkeww --platforms=ios --yes --ios-bundle-id=com.example.whodunnit
Downloading packages... .
  dart_console 1.2.0 (4.1.1 available)
  intl 0.18.1 (0.20.1 available)
  pub_updater 0.4.0 (0.5.0 available)
  pubspec 2.3.0 (discontinued replaced by pubspec_parse)
No dependencies would change in `/Users/russellwheatley/projects/flutterfire_cli/packages/flutterfire_cli`.
1 package is discontinued.
3 packages have newer versions incompatible with dependency constraints.
Try `dart pub outdated` for more information.
Building package executable...
Built flutterfire_cli:flutterfire.
i Found 23 Firebase projects. Selecting project dewqqqqkeww.
i Selected platforms: ios
i Firebase ios app com.example.whodunnit registered.

Firebase configuration file lib/firebase_options.dart generated successfully with the following Firebase apps:

Platform  Firebase App Id
ios       1:361461320736:ios:adb453c09faa7cd36f8045

Learn more about using this file and next steps from the documentation:
 > https://firebase.google.com/docs/flutter/setup

Might be worth upgrading to the latest:

dart pub global activate flutterfire_cli

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep open Needs Attention OP created or responded to issue and it needs attention. triage
Projects
None yet
Development

No branches or pull requests

2 participants