Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: if to add dot when creating a new project, it is not added to the actual project name #19

Open
1 task done
Shastel opened this issue Dec 17, 2023 · 5 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@Shastel
Copy link

Shastel commented Dec 17, 2023

Is there an existing issue for this?

  • I have searched the existing issues.

CLI Version

N/A

Project ID

N/A

Description

When creating a new project it is allowed to put a dot (.) to the name of the project. UI will allow it, but when the project is actually created there is no dot in the name

Steps to reproduce

  1. Go to globe.dev and press 'create project'
  2. Import any project repo from GitHub
  3. Edit the project name to contain a dot (i.e. api.my-test-project)GitHub

Expected behavior

Either not allow it on UI, or use it in the name (and domain?)

Screenshots

No response

Additional context and comments

Note: Github allows to create repositories with dot in the name

@Shastel Shastel added the bug Something isn't working label Dec 17, 2023
@Ehesp
Copy link
Member

Ehesp commented Dec 17, 2023

This isn't technically a bug. We slugify the name to become the project url, which we use for the dashboard, urls etc.

Probably need to change the wording here

@lesnitsky
Copy link
Contributor

I'd also expect whatever name was used initially to match the one in created project. It shouldn't be very hard to validate project name upon creation.

@Ehesp
Copy link
Member

Ehesp commented Dec 18, 2023

The idea was that it add less friction into the CLI flow, rather than trying to describe what is allowed/disallowed in the setup flow.

@Shastel
Copy link
Author

Shastel commented Dec 18, 2023

Sorry, it seems that I was not clear. The issue is with globe.dev UI, not CLI. I never checked if this (or similar) is actual for CLI.

@Ehesp
Copy link
Member

Ehesp commented Dec 18, 2023

Yeah that's my bad. Will add some validation on the frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants