Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Solving sibling dependencies in a monorepo via cli #31

Open
1 task done
robiness opened this issue Dec 30, 2023 · 2 comments
Open
1 task done

bug: Solving sibling dependencies in a monorepo via cli #31

robiness opened this issue Dec 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@robiness
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

CLI Version

0.0.2+1

Project ID

c1d0e2fd-dc3b-4894-be02-e114e1d7d4d7

Description

In a mono repo i get an error when deploying a project with a dependency on an other local package out of it's own scope (siblings in this case)

repo structure:

  • app (flutter)
  • shared (dart)
  • server (dart)

The 'app' and server depend on shared and are globe projects.

Error on deployment of the projects:

Resolving dependencies...
Because app depends on shared from path which doesn't exist (could not find package shared at "../shared"), version solving failed.

How would one deploy two projects within the same codebase? Especially when local dependencies aren't in the projects scope?

Steps to reproduce

I created a minimal version.

  • Clone the repo
  • run globe deploy at either app or server, both having a dependency on shared.

Expected behavior

globe deploy should run smoothly with a local dependency out of its own scope.

Screenshots

No response

Additional context and comments

No response

@robiness robiness added the bug Something isn't working label Dec 30, 2023
@robiness robiness changed the title bug: Solving sibling dependencies in a monorepo bug: Solving sibling dependencies in a monorepo via cli Dec 31, 2023
@robiness
Copy link
Author

It seems this is more a feature request to have the cli support monorepos.
I can set up both deployments via the dashboard to be auto deployed on pushs to branches. This works for now.
I am not sure what the exact expected behavior is.
Please feel free to close or let me know if it makes sense to create a new feature request for the cli to support mono repos.

@lesnitsky
Copy link
Contributor

@robiness we've made some changes to our build pipeline which should now allow monorepo without melos.
Example project: https://github.com/lesnitsky/globe_example_monorepo_no_melos.

@lesnitsky lesnitsky added enhancement New feature or request and removed bug Something isn't working labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants