Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong duration formatting in invoice with task details #2057

Open
cdahinten opened this issue Sep 17, 2024 · 4 comments
Open

Wrong duration formatting in invoice with task details #2057

cdahinten opened this issue Sep 17, 2024 · 4 comments
Assignees
Labels

Comments

@cdahinten
Copy link

Setup

  • Version: v5.10.27
  • Environment: Shared Hosting

Interface

  • Flutter: []
  • React: [X]
  • Both: []

Checklist

  • Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo?
    React Demo behaves similar to self hosted, Flutter drops errors when account+client country set to "german": Invalid country ID.
  • Have you searched existing issues?
    Yes, Forum
  • Have you reported this to Slack/forum before posting?
    No
  • Have you inspected the logs in storage/logs/laravel.log for any errors?
    No hint in logs.

Describe the bug

Setting localisation like this:
Bildschirmfoto 2024-09-17 um 11 46 02
Task settings like this:
Bildschirmfoto 2024-09-17 um 11 46 58
Results in Invoice-Details like this (should be "2,25 Stunden" instead of "2.2500 Stunden") wrong decimal-separator, too many decimals:
Bildschirmfoto 2024-09-17 um 11 51 43
Bildschirmfoto 2024-09-17 um 12 07 59

Steps To Reproduce

setup like screenshots above

Expected Behavior

Formatting should be e.g "2,25 Stunden" instead of "2.2500 Stunden"

Additional context

The react backend has no option to influence this behaviour probably (see flutter backend):
Bildschirmfoto 2024-09-17 um 12 50 39
The Linux App of which I guess is flutter-based works also not as expected – and not stable enough (Ubuntu 24.04.1 LTS, IN 5.0.158). It delivers mixed results:
Bildschirmfoto vom 2024-09-17 13-26-41

Screenshots

-above-

Logs

-don't contribute to the problem.

@turbo124 turbo124 transferred this issue from invoiceninja/invoiceninja Sep 19, 2024
@turbo124
Copy link
Member

@Civolilah please ensure client localized number formatting for the duration of task

@cdahinten
Copy link
Author

Thank you, @turbo124
the localized formatting should also work in "Reports" section (Screenshots).
This formatting issue leads to difficulties in number recognition e.g. here in latest LibreOffice. The Item description should contain the clean Text – not the markup-Version. Therefore the CSV gets really heavy to clean out. What do you think?

Bildschirmfoto 2024-09-19 um 15 31 08
Bildschirmfoto 2024-09-19 um 15 30 35
Bildschirmfoto 2024-09-19 um 15 32 39
Bildschirmfoto 2024-09-19 um 15 36 21

@turbo124
Copy link
Member

@Civolilah

The preview should provide a formatted export matching the company currency

@turbo124
Copy link
Member

@cdahinten are you able to create this as a separate issue so we can track these separately please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants