Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing brace wrongly indented #76

Open
rbauduin opened this issue Oct 22, 2023 · 3 comments
Open

closing brace wrongly indented #76

rbauduin opened this issue Oct 22, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rbauduin
Copy link

Describe the bug
The closing brace of a newly entered braces pair is idented wrongly after it is put on its own line.

To Reproduce
Press enter between braces so that the closing brace is placed alone on a line.

Expected behaviour
Closing brace is put at same indentation as opening brace

Screenshots

vim_indent_record.mp4

Environment (please complete the following information):

  • OS: Linux
  • Neovim version: NVIM v0.9.2
  • dotnet SDK version: 6.0.415
@rbauduin rbauduin added the bug Something isn't working label Oct 22, 2023
@cannorin
Copy link
Member

cannorin commented Nov 16, 2023

I think the whole syntax and indent files need to be revisited. They are from the ancient era, so they have some performance problems which can be solved today, and they also don't support the newest syntax of today's F#.

I think now is the best time to do this, since F# 8 has just been released with a lot of syntax changes.

@cannorin
Copy link
Member

I'm wondering if we can somehow import the syntax and indent configurations from Ionide-VSCode, so that we can avoid maintaining two versions of those files.

@JulesNP
Copy link
Contributor

JulesNP commented Nov 26, 2023

Since vim's indent program is in vimscript, using the VSCode version would be difficult to import, I believe.

I think Ionide should switch to the indent file from here: https://github.com/PhilT/vim-fsharp

I'm finding it very consistent and fast compared to Ionide's, after using it myself over the past few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants