Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need database for lessons #34

Open
rozig opened this issue Oct 8, 2018 · 10 comments
Open

Need database for lessons #34

rozig opened this issue Oct 8, 2018 · 10 comments
Assignees

Comments

@rozig
Copy link
Contributor

rozig commented Oct 8, 2018

@jackey8616 I think its time to add database for lessons. Writing lesson data in the code is not the right way to do it. At least, if you don't want to create a database lets save lesson data in JSON. What do you think?

@MinoLiu
Copy link
Contributor

MinoLiu commented Oct 8, 2018

🤔 I think JSON is a good choice.

@rozig
Copy link
Contributor Author

rozig commented Oct 8, 2018

I'm wondering why are you avoiding database ..

@MinoLiu
Copy link
Contributor

MinoLiu commented Oct 8, 2018

@rozig Because it will be difficult to maintain and contribute.

@rozig
Copy link
Contributor Author

rozig commented Oct 8, 2018

@Sean2525 @jackey8616 In my opinion that is not a big deal. I just wanted to share my idea with you, what if we develop the platform that teaches only Python and its technologies (Only python related frameworks, libraries and tools, such as Django, Flask, numpy etc) but in advanced level? People can add lessons through web interface and it will be created on database. But this is just the idea I came up with, if you don't like just ignore it.

@jackey8616
Copy link
Owner

@rozig
Your idea is very very good. And indeed, it's time to consider about centralized each lessons code with storage, such as JSON or DB that you mention earlier.
This platform, we strongly hope can running without any storage service, because we are not trying to running as a website to host it.
BUT, here is a BIG BUT,
For a complete service, I think a DB design is necessary for anyone who want to host it.

@jackey8616
Copy link
Owner

In my opinion is, we can make a simple toggle to switch b/w storage or not.
And I recommend using MongoDB to reduce the complexity of designing a schema.

@rozig
Copy link
Contributor Author

rozig commented Oct 8, 2018

Yes, we can use MongoDB. Can you add MongoDB integration?

@sawani02
Copy link

sawani02 commented Oct 9, 2018

Yes, mongodb is better choice, I can help with integration. Please do let me know!

@jackey8616
Copy link
Owner

@sawani02
If you have any good way at implement MongoDB, just fork and send a PR.
We can review the code and discuss more.

@sawani02
Copy link

@jackey8616 , Sure! I will implement it and will let you know, I've not yet push the code on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants