Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@keyv/redis] Migrate to node-redis from ioredis #1119

Open
jftanner opened this issue Sep 5, 2024 · 11 comments
Open

[@keyv/redis] Migrate to node-redis from ioredis #1119

jftanner opened this issue Sep 5, 2024 · 11 comments

Comments

@jftanner
Copy link

jftanner commented Sep 5, 2024

Is your feature request related to a problem? Please describe.
This was mentioned as part of #868, but not implemented as part of it. So this isn't new, but doesn't currently have an issue to track it.

With the effective deprecation of ioredis, devs are encouraged to switch to the official node-redis module instead. But, currently, that's not compatible with Keyv without a shim.

Describe the solution you'd like
One of two options:

  1. A new @keyv/node-redis module
  2. Migrate @keyv/redis to use node-redis instead.

In the latter case, it would either be a breaking change or would require a shim to still accept an ioredis instance passed to the constructor (new KeyvRedis(redis);).

@jaredwray
Copy link
Owner

@jftanner - we will be migrating to that soon and do plan to make it a breaking change moving forward.

#1018

@jaredwray jaredwray self-assigned this Sep 5, 2024
@jaredwray
Copy link
Owner

We are also considering using https://github.com/valkey-io/iovalkey to replace ioredis.

@jaredwray
Copy link
Owner

@100tomer

@100tomer
Copy link

100tomer commented Sep 5, 2024

Cool thanks for telling me about it. I already switched to another npm package but I'll be happy to switch back when it's ready.

@jaredwray
Copy link
Owner

Something to consider when looking at this. https://github.com/jaredwray/keyv/tree/ioredis-port-to-iovalkey

@jaredwray
Copy link
Owner

Cool thanks for telling me about it. I already switched to another npm package but I'll be happy to switch back when it's ready.

What library did you move too?

@jaredwray
Copy link
Owner

#1142

@jaredwray
Copy link
Owner

jaredwray commented Oct 8, 2024

@jftanner @100tomer - Wanted to update you on the plan that we are doing for Redis moving forward. Since ioredis is no longer being supported we are going to split things into two storage adapters:

  • @keyv/valkey - this is the open source redis server that is being supported by the linux foundation. We are in progress and will release it in the next couple weeks as it is based on the ioredis library now known as iovalkey. You can read more about Valkey by clicking on the link.
  • @keyv/redis - we will be porting this over to node-redis and fixing some things such as namespace issues in October and November but will do a major version release with this change.

@jaredwray
Copy link
Owner

https://www.npmjs.com/package/@keyv/valkey has been released 🎉

@mcollina thanks for the work on porting this over!

@jaredwray
Copy link
Owner

@klippx - adding this in here: #1174

@jaredwray
Copy link
Owner

Just FYI as we are working on the new version and should have it out in the next 2-3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants