-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@keyv/redis] Migrate to node-redis from ioredis #1119
Comments
We are also considering using https://github.com/valkey-io/iovalkey to replace ioredis. |
Cool thanks for telling me about it. I already switched to another npm package but I'll be happy to switch back when it's ready. |
Something to consider when looking at this. https://github.com/jaredwray/keyv/tree/ioredis-port-to-iovalkey |
What library did you move too? |
@jftanner @100tomer - Wanted to update you on the plan that we are doing for Redis moving forward. Since
|
https://www.npmjs.com/package/@keyv/valkey has been released 🎉 @mcollina thanks for the work on porting this over! |
Just FYI as we are working on the new version and should have it out in the next 2-3 weeks. |
Is your feature request related to a problem? Please describe.
This was mentioned as part of #868, but not implemented as part of it. So this isn't new, but doesn't currently have an issue to track it.
With the effective deprecation of ioredis, devs are encouraged to switch to the official node-redis module instead. But, currently, that's not compatible with Keyv without a shim.
Describe the solution you'd like
One of two options:
@keyv/node-redis
module@keyv/redis
to use node-redis instead.In the latter case, it would either be a breaking change or would require a shim to still accept an
ioredis
instance passed to the constructor (new KeyvRedis(redis);
).The text was updated successfully, but these errors were encountered: