Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while uploading changes... and they are then automatically removed!! #167

Open
bagage opened this issue Jun 16, 2018 · 3 comments
Open

Comments

@bagage
Copy link
Contributor

bagage commented Jun 16, 2018

Description:
I added a few benchs today with the application and logged into my OSM account via Google authentication (BTW: could you use real system authentication? currently it asks us for gmail password while it should not).

Anyway, when I tried to push my modifications, I got an error "There was an error during creation, your changes have been reverted." .

First of all, I believe there should be no error.
But even if there is some, please do not revert my work without asking me first!!!. That's very rude to remove all my work without asking simply because there was some kind of error while uploading these changes, even if these are unresolvable issues (conflict or similar).

[[BUG ONLY]]

Steps to reproduce:

  1. Login via gmail account
  2. Create a bench, upload it

Expected behavior:
Bench is uploaded.

Actual behavior:
Toast error "There was an error during creation, your changes have been reverted.". And revert of my work without asking.

Stacktrace (If it's a crash):

Environment:
Android 7.0 with EMUI 5.0.3
Huawei P8lite2017

Version:
v3.0.19

@bagage
Copy link
Contributor Author

bagage commented Jun 30, 2018

ping? no one to acknoledge a major bug that prevent using the application? Too bad since it's (the?) one of the best applications for osm contributions (as its name states ;)).

@loicortola
Copy link
Contributor

Hello @bagage
Thanks for your feedback.
We are having lots of trouble with OSM authentication.
The foundation does not provide a modern auth workflow and this hurts a lot when trying to provide a simple UX to our users (cf #145 ). I apologize for that and I hope the community moves towards a much needed modern approach towards this.

Regarding your work, I completely agree.
We have opened #111 to allow you to export potentially conflictual changesets into files, and then allow you to post-edit and troubleshoot in more detailed tools such as jOSM.

So far, our problem is not trying to find solutions, it's more of the lack of developers able and willing to spend some time on this beautiful app :(

I wish there was a way to enroll more community devs around this app and achieve more.

Thanks for your feedback anyway. If you are a dev, Let's get in touch !!

@bagage
Copy link
Contributor Author

bagage commented Jul 7, 2018

I tested on master version built on my machine, and it works on emulator (Nexus 5X API28). On my device (Huawei P8Lite2017), installing the exact same version result in the 401 authentication error.
Same account, same login (via credentials).

I looked a bit further, and saw that the transaction (changeset/create) http call succeed, but the inner transaction create POI call returns 401 Unauthorized.

I'm not much confident with OSM login stuff nor with osm-contributor development, but I hope one of your talented developer will find a fix soon! Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants