From 8afc721a5fe8a614f802578dc337fe3729426f58 Mon Sep 17 00:00:00 2001 From: Jim Klimov Date: Wed, 30 Nov 2022 13:32:29 +0100 Subject: [PATCH] PrintFailingTestsBuildToChatNotifier.java: move comment about code that confused spotbugs --- .../build_notify/PrintFailingTestsBuildToChatNotifier.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/hudson/plugins/im/build_notify/PrintFailingTestsBuildToChatNotifier.java b/src/main/java/hudson/plugins/im/build_notify/PrintFailingTestsBuildToChatNotifier.java index 7b88893..c13c959 100644 --- a/src/main/java/hudson/plugins/im/build_notify/PrintFailingTestsBuildToChatNotifier.java +++ b/src/main/java/hudson/plugins/im/build_notify/PrintFailingTestsBuildToChatNotifier.java @@ -71,14 +71,14 @@ private CharSequence getFailedTestsReport(Run build) { } StringBuilder buf = new StringBuilder(); - // SIC_INNER_SHOULD_BE_STATIC_ANON.... whatever that means: - // The class hudson.plugins.im.build_notify.PrintFailingTestsBuildToChatNotifier$1 - // could be refactored into a named _static_ inner class. // IDEA says: Unchecked assignment: 'java.util.List' to 'java.util.List'. // Reason: 'testResultAction' has raw type, so result of getFailedTests is erased. // and suggests to change to "raw" List, then complains it is raw :\ List failedTests = testResultAction.getFailedTests(); + // SIC_INNER_SHOULD_BE_STATIC_ANON.... whatever that means: + // The class hudson.plugins.im.build_notify.PrintFailingTestsBuildToChatNotifier$1 + // could be refactored into a named _static_ inner class. Collections.sort(failedTests, new Comparator() { @Override public int compare(CaseResult o1, CaseResult o2) {