Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.1.x] Remove deprecated classes/methods #12023

Open
sbordet opened this issue Jul 10, 2024 · 2 comments · Fixed by #12147 or #12149 · May be fixed by #12146
Open

[12.1.x] Remove deprecated classes/methods #12023

sbordet opened this issue Jul 10, 2024 · 2 comments · Fixed by #12147 or #12149 · May be fixed by #12146
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 10, 2024

Jetty version(s)
12.1.x

Description
Many classes carry over deprecated methods that can be removed, for example:

EndPoint.get[Local|Remote]Address().

Review what needs to be removed before the final release of 12.1.x.
@sbordet sbordet added the Bug For general bugs on Jetty side label Jul 10, 2024
sbordet added a commit that referenced this issue Jul 19, 2024
@sbordet
Issue #12023 - Remove WriteFlusher.Listener.
b267345 
WriteFlusher.Listener functionality was removed, and the class deprecated in 12.0.10 as part of the work for #9778 and #11839.

Signed-off-by: Simone Bordet <[email protected]>
sbordet added a commit that referenced this issue Jul 29, 2024
@sbordet
Issue #12023 - Remove WriteFlusher.Listener. (#12065)
f154f21 
WriteFlusher.Listener functionality was removed, and the class deprecated in 12.0.10 as part of the work for #9778 and #11839.

Signed-off-by: Simone Bordet <[email protected]>
sbordet added a commit that referenced this issue Aug 7, 2024
@sbordet
Issue #12023 - Remove deprecated classes/methods.
9e427dd 
Removed deprecated methods from AbstractConnectionPool.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 7, 2024 that will close this issue
Issue #12023 - Remove deprecated classes/methods. #12146
Open
sbordet added a commit that referenced this issue Aug 7, 2024
@sbordet
Issue #12023 - Remove deprecated classes/methods.
1585f7d 
Removed deprecated methods from EndPoint.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 7, 2024 that will close this issue
Issue #12023 - Remove deprecated classes/methods. #12147
Merged
sbordet added a commit that referenced this issue Aug 7, 2024
@sbordet
Issue #12023 - Remove deprecated classes/methods.
d22b068 
Removed deprecated classes/methods from jetty-client.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 7, 2024 that will close this issue
Issue #12023 - Remove deprecated classes/methods. #12149
Merged
@gregw
Copy link
Contributor

gregw commented Aug 19, 2024

I think our policy on removing deprecated API should be:

  • removed in any major release (e.g. 13.0.0)
  • removed in a minor release (e.g. in 12.1.0), but only when it has been deprecated for at least 6 patch released e.g. if current 12.0 release is 12.0.10, it must have been deprecated in or before 12.0.4
  • removed in a patch release if it was deprecated in a previous minor release, but with insufficient patch releases. e.g. if last 12.0 release was 12.0.10, then API deprecated in 12.0.8 can be removed in 12.1.3 (7th patch release).

This means that we can remove only in the next minor release, but only after 6 patch releases (approx 6 months).

@sbordet
Copy link
Contributor Author

sbordet commented Aug 23, 2024

I have captured this policy in #12194.

sbordet added a commit that referenced this issue Aug 23, 2024
@sbordet
Issue #12023 - Remove deprecated classes/methods.
b9bcb58 
Removed deprecated methods from EndPoint.

Signed-off-by: Simone Bordet <[email protected]>
sbordet added a commit that referenced this issue Aug 26, 2024
@sbordet
Issue #12023 - Remove deprecated classes/methods. (#12149)
272895c 
Removed deprecated classes/methods from jetty-client.

Signed-off-by: Simone Bordet <[email protected]>
@olamy olamy mentioned this issue Sep 29, 2024
Merged
@olamy olamy mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
2 participants
@gregw @sbordet