Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jj st does not show untracked files in directories #5389

Open
necauqua opened this issue Jan 18, 2025 · 4 comments
Open

jj st does not show untracked files in directories #5389

necauqua opened this issue Jan 18, 2025 · 4 comments

Comments

@necauqua
Copy link
Contributor

necauqua commented Jan 18, 2025

Description

With snapshot.auto-track set to none() jj st seems to only show untracked files at the root of the repository.

Steps to Reproduce the Problem

λ jj git init test
λ cd test
λ jj config set --repo snapshot.auto-track 'none()'
λ touch test-file
λ jj st
Untracked paths:
? test-file
Working copy : (m) b91c73c (empty) (no description set)
Parent commit: (z) 0000000 (empty) (no description set)
λ mkdir test-dir
λ touch test-dir/something
λ jj st
Untracked paths:
? test-file
Working copy : (m) b91c73c (empty) (no description set)
Parent commit: (z) 0000000 (empty) (no description set)

Expected Behavior

Second jj st should've shown a ? test-dir/something line, or maybe a ? test-dir line if the entire dir is untracked.

Actual Behavior

It doesn't show that, and in fact if test-file was not there it would say "The working copy is clean"

Specifications

  • Platform: NixOS
  • Version: jj 0.25.0-f7431650bea45f22421951058949ebacabb1de9a
@necauqua
Copy link
Contributor Author

If we do

λ touch test-dir/tracked
λ jj file track test-dir/tracked

The test-dir/something still wont show up

And if we commit the test-dir/tracked it wont show up either

@yuja
Copy link
Contributor

yuja commented Jan 18, 2025

auto-track = none() makes all directories untracked (or non-auto-tracked to be precise.) New untracked files in those directories aren't caught right now.

BTW, there's another issue that jj status won't notice untracked files if watchman is enabled.

@martinvonz
Copy link
Member

@cstoitner, are you interested in fixing this?

@cstoitner
Copy link
Contributor

I had planned to get back to this.

Recursing into untracked directories is not implemented yet. Maybe I can find some time to look at this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants