Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE #5 - Download JSON/CSV Option on Bulk Actions Complete #8

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

JayeshVP24
Copy link
Contributor

@JayeshVP24 JayeshVP24 commented Aug 8, 2023

Resolves #5

image

Download JSON & CSV File

  • This PR adds a Download JSON and Download CSV option to bulk generate dialog.
  • JSON works with everything
  • CSV works with everything including Nested Arrays (One Level), String Delimiters (strings with commas, quotes)
  • CSV works with Generated JSON in DataType, but keeps single JSON in single line. All generated JSONs are separated by line as done in a CSV file.

Extras :)

  • Solved an unknown bug.
    • To reproduce, enter one item, any item to go into bulk mode, you can change the number of items here, then click enter instead of manually clicking generate.
    • when bulk action dialog is one, clicking enter to submit form also clicks the item from where the dialog was called making it call its onclick function which in-turn copies single value into clipboard making the bulk generated one useless.

@jofftiquez
Copy link
Owner

Hi @JayeshVP24 thank you so much for this. I will review this asap! 💪

@jofftiquez jofftiquez changed the base branch from main to testing August 18, 2023 08:47
@jofftiquez
Copy link
Owner

Merging to testing branch for local testing

@jofftiquez jofftiquez merged commit 9c93ccc into jofftiquez:testing Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: download output via csv or json
2 participants