-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legion Slim 5 16APH8 Support #76
Comments
@brett-owen Sorry, for the late response. Currently, there are lots of issues and a also work on lots of other stuff. Is this a 2023 model? I added your model/BIOS to the kernel module. Please get the new version, recompile, and reload the kernel module (no need to force anymore). Then, please test the following features. We have to try a bit to find the correct configuration. Temperatures and Fan SpeedsPlease read the fan speeds and temperatures (see README) and confirm that they are sensible and change accordingly, e.g. when you put load onto the CPU the CPU temp and the fan speeds should increase, but GPU temp should stay roughly the same. PowermodeWe will start by confirming that power mode change work and to get me more debug info. Please change the power mode with Fn+Q and provide the output of the following commands in each mode. sudo cat /sys/kernel/debug/legion/ecmemoryram | hexdump -C
sudo cat /sys/kernel/debug/legion/ecmemory | hexdump -C
sudo cat /sys/kernel/debug/legion/fancurve Then please also check if the power mode is read correctly in the OS (see README). Then please check if you can set the power mode with the GUI (see README) and the LED changes accordingly. Tests the following features with the GUI. Please check that if works or otherwise give precise information about what does not work. Please try to check that reading and writing works with the software. Please provide the log output from the GUI from the log tab for all the tests. Fn Lock
Win Key
Touchpad
Battery Conservation
Rapid Charging
Charge Output Always On
Display Overdrive
Keyboard BacklightIn order to fix/configure the keyboard backlight and begin with setting fan curves, please put your keyboard backlight to off, medium, or bright. Provide the output of the following commands (in that order) in each backlight state: sudo cat /sys/kernel/debug/legion/fancurve
sudo dmesg | tail -n 30 Fan curveFirst, please give again the output of sudo cat /sys/kernel/debug/legion/fancurve
sudo dmesg | tail -n 30 Second, please use the GUI and enter custom mode. Then change the fan curve (currently only the first row for fan 1), write it to hardware, and read it back. Please report back if it works and provide the log output from the GUI and |
@brett-owen pls report back if the driver works |
@MrDuartePT I have the same model and the error still persists with the current main. I get these messages: |
The acpi error is nothing to do with the legion driver. About the error try make forcereloadmodule. |
Also give me the dmidecode output. Beside the model being the same. Depending of the CPU and GPU config the bios and ec id could change. |
@MrDuartePT sorry for the late response Handle 0x0000, DMI type 0, 26 bytes fancurve:
|
Also give me the dmesg only of the legion driver after forcereloadmodule what to check one thing. |
Also the hexdump for the 3 power modes: |
Hexdump
|
Sorry I give the wrong command edit with this and pls clean up some the dmesg:
|
second
|
Also when I use the sensor command the fans are off(0 rpm) |
I'm having problems using 0.0.9-prerelease as well.
|
The problem with the fancurve is that hexdump don’t give a identification of what values are temps and fan speed. |
@MrDuartePT What are the steps involved to reverse engineer the EC for gen 8 support (I have a 14APH8)? |
I scratching this ideia is very time consuming and probably not worth the hassle since it can change from model to model. If you want to help the better approach is to find the acpi_call for the wmi implemented by Lenovo. https://github.com/hhd-dev/hwinfo/tree/master/devices/Legion_Pro_5_16IRX9 https://github.com/hhd-dev/hwinfo/blob/master/devices/legion_go/readme.md Note: In reality no one reversed the ec to legion go what happen is on gen 8 and later Lenovo finally implemented the wmi for the fan curve control we just need find how to get the table and alter it since it not exact the same values as the legion go. |
@MrDuartePT Should I make PR against hwinfo with the dumps for my machine (removing serial number and UUID)? |
@MrDuartePT I was wondering what you want me to do with the dumps (for Legion Slim 5 14 14APH8) you described previously. Are they still useful to you? Should I make a PR against hwinfo? |
Sorry didn't notice your reply. You can do if hwinfo dosent have your device already, help to know if something changes between the slim and regular legion |
@MrDuartePT I have made the PR against hwinfo: hhd-dev/hwinfo#17 |
I also have Legion Slim 5 14 14APH8. I see the PR hhd-dev/hwinfo#17 is now merged. What else is needed to support this model? And can I help in any way? |
That is not support for any driver of some sort that is only hw logs, that will help supporting new laptop. The Legion GO PR will help support new devices. After we finalize that will process to add all the gen 8 and maybe gen 9 devices. Also fan control on newer model (basically what is mainly broken on new model), might only work on custom mode (like LLT) |
Also someone pls do all the test in here (besides the fan curve): #76 (comment) To be sure what is working or not Also check if possible to change the power modes using the gui and see if this option work on the gui: Also dont post any hexdumps I dont need them for now |
I could do the tests for Legion Slim 5 14APH8, but right now I get this message:
Could you add 14APH8 to the allowlist? I provided some info of my model in #46 (comment) if that's helpful. |
clone the repo and run in the |
Thanks, I see it wasn't loading because I didn't have the "force=1" parameter for the kernel module. I can confirm that the following options work in the GUI:
❌ Charge Output Always On cannot be turned off: the field becomes red after trying to uncheck it. Log after clicking the checkbox
❌ Display Overdrive doesn't work: the checkbox cannot be checked. ✅ Changing Keyboard Backlight modifies the
( |
Also, each power mode setting changes Quiet
Balanced
Performance
FanspeedThe following options also get changed but their value depends on the CPU/GPU usage:
|
Thanks @jul1u5 I gonna look in to it. |
I have a 16APH8, anything I can do to help investigate getting the module to run? I haven't had much luck yet even getting the module to compile, but I'd like to help. Running Fedora Silverblue 40. I don't know how different the 16APH8 is from the 14APH8 but I will run the tests mentioned here. Doesn't look like there's a lot of activity on the PR itself, and I'm a rust dev, or else I'd try to provide code help too. |
Any update on the Slim 5 14APH8? I've tried TLP, PowerTop, Auto-cpufreq, even System76-power and none is giving me anything remotely close to the Windows Toolkit/Vantage :( |
Model name: Lenovo Legion Slim 5 16APH8
CPU model: AMD Ryzen 7 7840HS
GPU model: NVIDIA RTX 4060 Mobile
Keyboard backlight: RGB
OS: Archlinux
Output of
sudo dmidecode -t system
. Please remove Serial Number and UUID for privacy:Output of
sudo dmidecode -t bios
:Output of
sudo cat /sys/kernel/debug/legion/fancurve
:fwts_wmi.log
acpi_re.tar.gz
wmi_windows.txt
Output of
sudo make forcereloadmodule
:Thanks, let me know if you need any more information to get this model working.
The text was updated successfully, but these errors were encountered: