Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show less is showing ...show less #18

Open
govindmaheshwari2 opened this issue Jun 1, 2021 · 7 comments
Open

show less is showing ...show less #18

govindmaheshwari2 opened this issue Jun 1, 2021 · 7 comments

Comments

@govindmaheshwari2
Copy link
Contributor

show less is showing "...show less" it should be "show less" only. please fix it.

@ronytesler
Copy link

@govindmaheshwari2 You can set 'delimiter' to ''. (delimiter: '') then set trimCollapsedText to something like '...show more' and trimExpandedText to 'show less'.

@SalahAdDin
Copy link

SalahAdDin commented Jul 16, 2021

@ronytesler shouldn't it be the default behaviour?

Also, if you "remove" the delimiter, it won't be a space between the text and the button:
image

@ronytesler
Copy link

@SalahAdDin Of course, just wanted to give a workaround.
You can add a space to your text or the delimiter or trimExpandedText. Again, just a workaround.

@SalahAdDin
Copy link

@SalahAdDin Of course, just wanted to give a workaround.
You can add a space to your text or the delimiter or trimExpandedText. Again, just a workaround.

Yeah, it works for me.

@jonataslaw what do you think about this?

@nxcco
Copy link

nxcco commented Aug 16, 2021

Needing a workaround is kind of annoying. I love this package and would like to see this feature implemented :D

@nxcco
Copy link

nxcco commented Aug 16, 2021

Oh I saw it's due to that the package on pub was not updated yet. Sorry for that!

@SalahAdDin
Copy link

Oh I saw it's due to that the package on pub was not updated yet. Sorry for that!

There is no any update relate to this, and it seems the maintainer is not active anymore, you could do a patch/pull request and contribute to this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants