Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "reasonable" way for early adopters to integrate into a Bazel build #23

Open
cpovirk opened this issue Apr 25, 2023 · 3 comments

Comments

@cpovirk
Copy link
Collaborator

cpovirk commented Apr 25, 2023

Similar to #22 in the sense that we've done nothing for Bazel yet.

Internally, we use java_package_configuration. But there's a bit more to it than that, so we might just want to have people set exported_plugins on a common dep or something??

Anyway, we're tentatively leaving Bazel integration off the current milestone because Bazel is less common than Maven and Gradle. But if we hear of an interested party who uses Bazel, we can probably whip something up without too much trouble.

@vorburger
Copy link

But if we hear of an interested party who uses Bazel

An interested party is hereby raising interest for this interesting idea! 😄

IFF adopting this (jspecify-reference-checker) is recommended in enola-dev/enola#845?

@vorburger
Copy link

I guess the ("reasonable" ?) endgame here would be to have a jspecify-reference-checker up over on https://registry.bazel.build, which would let one easily switch their java_library over to (something like) a java_library_with_nullness_check sort of Bazel rule?

@cpovirk
Copy link
Collaborator Author

cpovirk commented Aug 19, 2024

Thanks. I left a response over there. To elaborate a little here:

The primary value that the reference checker provides over EISOP is that the reference checker is more lenient when dealing with unannotated code.

The primary value that the reference checker provides over NullAway is that the reference checker has significant support for generics.

Given that, it's probably not the best choice for your particular project. If we had it ready to integrate easily, I'd for sure tell you to try just so that we get some more hands-on usage :) But now, it's strictly harder to integrate than EISOP, which I suspect is strictly harder than NullAway. We'll get there eventually, and I appreciate knowing of the interest. Still, I'd suggest not right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants