Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing __version__ from jss prevents pip install from working with pre-installing requirements #100

Open
pboushy opened this issue Jul 10, 2020 · 0 comments

Comments

@pboushy
Copy link

pboushy commented Jul 10, 2020

If you try to install python-jss from source using pip install, you get several errors that you need to install six, requests, etc.

pip is capable of installing these dependencies for python-jss, but can't because setup.py is trying to import jss and failing on the dependencies (chicken and the egg scenario)

There are multiple ways to solve this:

  1. set the version in setup.py
  2. Choose one of the methods for single-sourcing-the-version listed https://packaging.python.org/guides/single-sourcing-package-version/#single-sourcing-the-version

By doing this it will simplify the installation of python-jss.

After some discussion on this, I'm glad to submit a pull request for the change.

Personally, since the version isn't used anywhere except setup.py currently, I'd recommend we set it statically in setup.py, and can revisit that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant