Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named Anchor gets dropped #12

Open
dedman opened this issue May 4, 2011 · 1 comment
Open

Named Anchor gets dropped #12

dedman opened this issue May 4, 2011 · 1 comment

Comments

@dedman
Copy link

dedman commented May 4, 2011

Hey,

We are just upgrading from rack-rewrite 0.2.1 to 1.0.2 and we noticed that named anchors are not getting included in the redirect path.

For example if you try to redirect the url "/Test?q=cool#notcool" with a regex or other means the resultant redirect path will not include the #notcool on the end.

It looks like this is because your using env['REQUEST_URI'] in line 74 or rule.rb 0.2.1 and env['PATH_INFO'] + "?" + env['QUERY_STRING'] in line 159 1.0.2.

Is it an intentional change? or just a mistake?

Thanks

@jtrupiano
Copy link
Owner

This is a mistake-- I'll happily accept a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants