Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cookies in a more systematic way? #298

Open
danielcompton opened this issue Jun 4, 2019 · 0 comments
Open

Handle cookies in a more systematic way? #298

danielcompton opened this issue Jun 4, 2019 · 0 comments

Comments

@danielcompton
Copy link
Contributor

danielcompton commented Jun 4, 2019

The code for validating cookies, cookies on resources, cookie encoding, e.t.c. is in several different locations across several files, and there is some duplication between them. This makes it hard to tell if all cookie attributes and value types are handled in all possible ways of creating them (#296, #297).

I'm not quite sure what it would look like, but it might be good to look at merging the handling of cookies into one unified place so that they can be handled consistently throughout the yada stack?

OTOH, cookie attributes aren't added that frequently, so if it's too difficult then it may not be worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant