Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer tests overflow end stats #52

Open
1 of 3 tasks
jwbensley opened this issue Apr 14, 2018 · 1 comment
Open
1 of 3 tasks

Longer tests overflow end stats #52

jwbensley opened this issue Apr 14, 2018 · 1 comment

Comments

@jwbensley
Copy link
Owner

ISSUE TYPE
  • Bug Report
  • Enhancement/Feature Request
  • Question
VERSION DETAILS
Etherate version 1.17 2018-04
SUMMARY

When running a longer test, e.g.5 minutes, the average bps/fps counters are overflowing:
Average speed during test: 352123.25Mbps, 709925909Fps

STEPS TO REPRODUCE
sudo taskset -c 2 ./etherate -i ens2f0 -t 3600 -f 48
...
900		392.23		41929		790782		709133369
901		393.10		41976		792540		709925909
^CQuitting...
Test frames transmitted: 710465807
Test frames received: 0
Non test frames received: 16
In order ACK frames received: 0
Out of order ACK frames received early: 0
Out of order ACK frames received late: 0
Maximum speed during test: 393.10Mbps, 792540Fps
Average speed during test: 352123.25Mbps, 709925909Fps
Data transmitted during test: 42008MBs
Leaving promiscuous mode
@jwbensley
Copy link
Owner Author

jwbensley commented Jun 9, 2018

https://github.com/jwbensley/Etherate/blob/master/speed_tests.c#L435

b_speed_avg is a long doube, change to uint64_t (N.B. b_speed and b_speed_max as double):

Then replace:
eth->speed_test.b_speed_avg += eth->speed_test.b_speed;
with:
eth->speed_test.b_speed_avg += (eth->speed_test.b_tx - eth->speed_test.b_tx_prev)

This needs to have for both Tx and Rx and for all speed test functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant