Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouterInterface delete is not robust to unavailable router #197

Open
mdbooth opened this issue Jan 29, 2025 · 0 comments
Open

RouterInterface delete is not robust to unavailable router #197

mdbooth opened this issue Jan 29, 2025 · 0 comments

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Jan 29, 2025

The behaviour of the RouterInterface controller is not ideal when we're waiting on the router:

  • The router has not been created
  • The router is currently marked unavailable

In both of these cases we don't proceed to reconcile the RouterInterface at all. At a minimum we should still iterate over RouterInterfaces and report the status as waiting on the router.

We also have a robustness issue in the case that the router is not marked as available and we are trying to delete attached RouterInterfaces. In this case, we will also never attempt to delete the RouterInterfaces. In general, I think we should attempt to delete a RouterInterface regardless of the state of its attached router, as long as the router has an ID set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant