Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server (and possibly others) do accidental substring match on name during adoption #250

Open
mdbooth opened this issue Feb 7, 2025 · 0 comments · May be fixed by #254
Open

Server (and possibly others) do accidental substring match on name during adoption #250

mdbooth opened this issue Feb 7, 2025 · 0 comments · May be fixed by #254

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Feb 7, 2025

I created a server called bastion and it imported an existing server called foo-bastion. Server should obviously be doing more robust adoption than just a name match, but in any case we should be matching the whole string not just a substring.
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 11, 2025
@itzikb-redhat
Adding a test for server adoption
f18e9b6 
Create one server named 'create-adoption'.
Create another server with the substring of the first - 'adoption'
Test that the resource name of the second server is 'adoption'.

Reference: k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 11, 2025
@itzikb-redhat
Adding a test for server adoption
79d9421 
Create one server named 'create-adoption'.
Create another server with the substring of the first - 'adoption'
Test that the resource name of the second server is 'adoption'.

Reference: k-orc#250
@itzikb-redhat itzikb-redhat mentioned this issue Feb 11, 2025
Closed
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 11, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
ea3dc4c 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 11, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
13f5ec2 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Fixes k-orc#250
@itzikb-redhat itzikb-redhat linked a pull request Feb 11, 2025 that will close this issue
Open
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 13, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
933a54d 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 13, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
08ef35a 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 13, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
37f3cd0 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
ce2ebff 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
8452e0c 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
806f927 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
38a1e38 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
2dd6cf0 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 16, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
067e4ec 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 17, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
7d7baea 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 20, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
0e806bf 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 20, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
a7dbde4 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
itzikb-redhat added a commit to itzikb-redhat/openstack-resource-controller that referenced this issue Feb 24, 2025
@itzikb-redhat
Use a regular expression in server ListOSResourcesForAdoption
598f21e 
In adoption use a regular expression to get a specific server instead of using the name
as it is which can lead to getting servers that contain the server name in their names
Example: We look for 'foo' where there is a server 'foobar'

Also added a test for server adoption
 - Create one server named 'create-adoption'.
- Create another server with the substring of the first - 'adoption'
- Test that the resource name of the second server is 'adoption'.

Done the same for import - same fix and added a test
Fixes k-orc#250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mdbooth