Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NATS Server embedded as an option #189

Open
gedw99 opened this issue Nov 14, 2023 · 2 comments
Open

NATS Server embedded as an option #189

gedw99 opened this issue Nov 14, 2023 · 2 comments

Comments

@gedw99
Copy link

gedw99 commented Nov 14, 2023

User Story

As a developer and operator I would like to have the option to run NATS Server embedded, so that I can run this system with or without a NATS Server.

This makes it easy to run on VPS or bare mental where port 25 is available too. Fly.io is an example of a hosting solution that allows port 25, and is an easy Docker deploy.

K8 is not effected by this, because the proposed solution for Config means that if a NATS Server URL is supplied then it used an external NATS Server.

Detailed Description

Nats Server has a simple way to do this.

https://github.com/maxpert/marmot/blob/master/stream/embedded_nats.go shows how its used.

https://github.com/maxpert/marmot/blob/master/stream/nats.go#L27C2-L27C2 shows the check to use the embed nats server or not.

Anything else

Config just needs a toggle to enable this. The checker above assumes to use embedded if its NOT in the .env config, which is a sensible way

@gedw99
Copy link
Author

gedw99 commented Nov 14, 2023

Looks like the .env file is missing the NATS line ?

https://github.com/kannon-email/kannon/blob/main/.env should have a NATS line but does not

https://github.com/kannon-email/kannon/blob/main/pkg/dispatcher/dispatcher.go#L25 calls it..

@gedw99 gedw99 changed the title NATS embedded as an option NATS Server embedded as an option Nov 14, 2023
@ludusrusso
Copy link
Collaborator

ludusrusso commented Mar 6, 2024

Hi @gedw99,
sorry for the delay but I've completely miss the notification (too much notification from github) :D

Thanks for this, I didn't know it was possible.

I'm not having much time to maintain this project but I have the idea to simply the deployment and I'll take in consideration this issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants