Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_multiple doesn't document result order #315

Open
ecton opened this issue Mar 11, 2024 · 2 comments
Open

get_multiple doesn't document result order #315

ecton opened this issue Mar 11, 2024 · 2 comments

Comments

@ecton
Copy link
Member

ecton commented Mar 11, 2024

The implementation of get_multiple does not document that the returned list's order is not guaranteed. Additionally, we might want to add another function such as get_multiple_ordered that performs the additional step of sorting the results to match the input request, minus any missing items.

Originally inspired by a question by @martpie in #237 (comment)
@martpie
Copy link

martpie commented Mar 11, 2024

I can maybe work on a PR if you don't have the bandwidth :)

@ecton
Copy link
Member Author

ecton commented Mar 12, 2024

I'm not currently focused on this project but don't mind tackling this once I get back to BonsaiDb. But I'm also more than happy to accept a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecton @martpie