Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More informative error handling #37

Open
dchiquito opened this issue Jul 28, 2021 · 0 comments
Open

More informative error handling #37

dchiquito opened this issue Jul 28, 2021 · 0 comments

Comments

@dchiquito
Copy link

dchiquito commented Jul 28, 2021 •
edited
Loading

If the authorizationServerBaseUrl argument passed to OauthClient is not a complete URL, no exception will be thrown until the openid RedirectRequestHandler attempts to build a new URL(...) object out of it. Sadly, the error is swallowed by this try/catch: https://github.com/girder/girder-oauth-client/blob/36bbcbe8a9f5b03d37c84a338a77ec7746845cad/src/oauth-client.ts#L45-L51

Either an earlier check for this malformed user input or a more specific catch would have saved me a few hours of debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dchiquito