1107 improve live activities #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
- Coverage 36.18% 35.07% -1.11%
==========================================
Files 134 135 +1
Lines 7730 7808 +78
==========================================
- Hits 2797 2739 -58
- Misses 4933 5069 +136 ☔ View full report in Codecov by Sentry. |
…that of its containing parent app ('3.8.0')
kelson42
force-pushed
the
1107-improve-live-activities
branch
from
ecd19f8 to
ce266fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1107
UI:
I have changed the background for the live-activity, so it matches the look and feel of other widgets on the Lock Screen. There's one issue though, Apple's environment property:
isActivityFullScreen has a bug, when we use min iOS is 16. According to their docs it has been "back-ported", but in reality using it is breaking the live-activity, and nothing will show up. Not using it is at the moment OK, I think, the only side effect is that in iPhone standby mode the live activity background is blurred instead of black. We can solve this only by updating to min iOS 17.
Update frequency
Long story short: local updates for "live" activities can get ignored by the system if we send them too often. From my tests it seems that updating the live activity every 10 seconds, is stable enough.
I have added a countdown timer, that is showing that something is happening for the user, although the calculations of that is approximate. We update the "start time" of the counter every 10 sec, so it might jump up or down, plus we update the amount downloaded and the progress spinner every 10 sec.