Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 为所有官方插件中的 Duration 类型添加单位标注 #1203

Open
2 tasks
ilharp opened this issue Sep 18, 2023 · 1 comment
Open
2 tasks
Labels
feature 新特性

Comments

@ilharp
Copy link
Member

ilharp commented Sep 18, 2023

Describe the problem related to the feature request

image

以全局设置为例,8 个配置项里只有一个标了单位的,剩下的都没有单位标注。新手几乎总不能只凭借给出的信息判断这些配置项的单位。

Describe the solution you'd like

为所有官方插件中的 Duration 类型添加单位标注,类似 timezoneOffset

Describe alternatives you've considered

在醒目的地方(如全局设置的 usage)标注 Duration 没说一律毫秒。这么做有两个缺陷:

  1. 标识与具体的配置项相隔很远,看配置项的时候无法立即记起单位标识,也容易忽略;
  2. 如果第三方插件没有单位标识并且并不使用毫秒,全局的标识会对插件配置造成误导。

Checklist

这些包或插件需要作出修改:

@ilharp ilharp added the feature 新特性 label Sep 18, 2023
@shigma
Copy link
Member

shigma commented Sep 19, 2023

之后会为有单位的量专门做外观,可能等做完以后优化这里。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 新特性
Projects
None yet
Development

No branches or pull requests

2 participants