Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] remove long-deprecated python based visualizations #11133

Open
gregsheremeta opened this issue Aug 23, 2024 · 1 comment · May be fixed by #11134
Open

[feature] remove long-deprecated python based visualizations #11133

gregsheremeta opened this issue Aug 23, 2024 · 1 comment · May be fixed by #11134

Comments

@gregsheremeta
Copy link
Contributor

What feature would you like to see?

As far as I can tell, there are two primary categories of visualization in Kubeflow Pipelines:

  • output viewer visualizations
  • so-called "python based visualizations"
    • has two subcategories, "predefined" and "custom"

Output viewer visualizations are the original visualizations that were included in Kubeflow Pipelines long ago.

In 2019, Kirin Patel introduced "Python based visualizations" to Kubeflow Pipelines (commits, blog post).

Note the introduction of the "visualization server".

In 2020, Kirin had left the project, and the Kubeflow Pipelines community decided to deprecate Python based visualizations.
issue PR

The recommendation became to use notebooks or the HTML output viewer to accomplish what you could have using the "Python based visualizations" feature.

Post deprecation, there was a lot of language left over in the output viewer documentation that described "Python based visualizations" as the "new" way to do visualizations. This was confusing. I've previously posted a PR to clean some of that up, but much lingers.

It's been 4 years since it was deprecated. It probably should have been removed when Kubeflow Pipelines 2.0 was released.

Let's remove it now.

@gregsheremeta
Copy link
Contributor Author

One thing I'm not sure how to do: how does Kubeflow / KFP handle cleaning up deprecated and deleted things? Should we include some kind of upgrade scripts of manifests that are capable of cleaning up Deployments, Roles / RBAC, SAs, etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant