Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CertManager for the Webhook cert generation #2049

Open
tenzen-y opened this issue Apr 10, 2024 · 11 comments · May be fixed by #2426
Open

Support CertManager for the Webhook cert generation #2049

tenzen-y opened this issue Apr 10, 2024 · 11 comments · May be fixed by #2426
Assignees
@Garvit-77 @tariq-hasan
Labels
good first issue help wanted kind/feature

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Apr 10, 2024 •
edited
Loading

/kind feature

Currently, the training-operator generates certs for the webhook using the internal cert generation mechanism for all installation ways.

However, we know that some administrators prefer to use the cert-manager to manage all certifications for security and so on.
So, I would suggest supporting the cert generation mechanism by the cert-manager.

xref: #2035
@tenzen-y
Copy link
Member Author

/kind feature

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 9, 2024

/remove-lifecycle stale

@andreyvelich
Copy link
Member

/good-first-issue

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tariq-hasan
Copy link
Contributor

/assign

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/remove-lifecycle stale

@Garvit-77
Copy link

Heyy @tariq-hasan are you still working on this issue ?
if not @andreyvelich could you please assign me this issue ?

@andreyvelich
Copy link
Member

Sure, but I suggest that we implement this feature for Kubeflow Training V2 given that V1 is already released.
/assign @Garvit-77

@Garvit-77
Copy link

Thanks, @andreyvelich ,
So should I wait for an announcement of 2.0, or I can go ahead and solve the issue

@Garvit-77 Garvit-77 linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garvit-77 Garvit-77

@tariq-hasan tariq-hasan

Labels
good first issue help wanted kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add internal-cert-controller disable flag Garvit-77/training-operator
4 participants
@andreyvelich @tenzen-y @Garvit-77 @tariq-hasan