Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to check and warn if az cli if unavailable in local #5291

Open
Tracked by #5257
nawazkh opened this issue Nov 19, 2024 · 7 comments · May be fixed by #5335
Open
Tracked by #5257

Update Makefile to check and warn if az cli if unavailable in local #5291

nawazkh opened this issue Nov 19, 2024 · 7 comments · May be fixed by #5335
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@nawazkh
Copy link
Member

nawazkh commented Nov 19, 2024

With #5288 being added to CAPZ, tiltfile will depend on az commands to peer mgmt and workload cluster VNets.
We should be updating make tilt-up command (probably as an additional dependency? )to check and warn the user az cli if not present in the local.

@nawazkh nawazkh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 19, 2024
@brettearle
Copy link

I'm happy to jump on this

@willie-yao
Copy link
Contributor

/assign @brettearle

Hi! Just wondering if you were still planning to work on this?

@brettearle
Copy link

Yeah I'll jump on it, is there a discord/slack etc for questions or is here the best?

@willie-yao
Copy link
Contributor

Sweet thank you! You can find us in the Kubernetes Slack: https://github.com/kubernetes-sigs/cluster-api-provider-azure?tab=readme-ov-file#getting-help

@brettearle brettearle linked a pull request Dec 16, 2024 that will close this issue
4 tasks
@brettearle
Copy link

@willie-yao Hey mate, I have a couple of questions.

Are we covering all 3 os's?

Az has an install script for Linux. The script depends on openssl, python 3.8+, and libffi. What would you like to do when these are not available? I saw that the project supports Python 2.7, which will not work with this.

Do we want to reach across the network to get the install script or keep the script locally for the project?

@willie-yao
Copy link
Contributor

Hi @brettearle!

Yes we should be covering all 3 os's

I think those are just a pre-requisite for CAPZ and your command shouldn't need to account for them.

If possible, it would be better to go across the network to get the install script!

If you'd like an example PR for something similar to this, check out #3630. @nawazkh Can you verify if the logic will largely be the same?

@nawazkh
Copy link
Member Author

nawazkh commented Jan 27, 2025

Hey @brettearle and @willie-yao ! Great depth analysis to this challenge here.

The aim of this issue is to let the user know "hey , you do not have azcli installed in your local. Please install it before moving forward."

So the way I see it, this issue can be broken down to two goals.

  1. Check if az is installed in user's local.
  2. Install az cli if not present.

Not that I think of it with your comment @brettearle (#5291 (comment)), installation of azcli could be unnecessary. User might have their own preference on installing a cli tool, brew, apt-get, macports, curl and move etc.
So, I think, we can drop the second goal of this issue of installing azcli and reduce the scope to first goal; "check and warn if az cli is not installed in local".

I will update this issues description as well.

@nawazkh nawazkh changed the title Update Makefile to install az cli if unavailable Update Makefile to check and warn if az cli if unavailable in local Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants