Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove finalizer when cloud resource is found absent #220

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Remove finalizer when cloud resource is found absent #220

merged 1 commit into from
Dec 10, 2020

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Dec 7, 2020 •
edited
Loading

What this PR does / why we need it:
Remove finalizer when cloud resource is found absent.

This is to ensure that reconciles can complete even when cloud resources (droplets, LBs) cannot be referenced anymore.

Which issue(s) this PR fixes:
Fixes #218
Fixes #219

Release note:

Remove finalizer when cloud resource is found absent

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2020
@k8s-ci-robot
Copy link

Hi @timoreimann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2020
xmudrii
xmudrii reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit otherwise looks fine to me.

@xmudrii
Copy link
Member

xmudrii commented Dec 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2020
@timoreimann
Remove finalizer when cloud resource is found absent
34d5b09 
This is to ensure that reconciles can complete even when cloud resources
(droplets, LBs) cannot be referenced anymore.
@timoreimann timoreimann force-pushed the remove-finalizer-when-cloud-resource-is-found-absent branch from 8479fcd to 34d5b09 Compare December 7, 2020 20:53
@timoreimann
Copy link
Contributor Author

@xmudrii implemented your suggestion, thanks.

prksu
prksu approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@prksu prksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2020
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prksu, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4fc3ece into kubernetes-sigs:master Dec 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Dec 10, 2020
prksu pushed a commit to prksu/cluster-api-provider-digitalocean that referenced this pull request Dec 11, 2020
@timoreimann @prksu
Remove finalizer when cloud resource is found absent (kubernetes-sigs…
af40d59 
…#220)

This is to ensure that reconciles can complete even when cloud resources
(droplets, LBs) cannot be referenced anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

@prksu prksu prksu approved these changes

@detiber detiber Awaiting requested review from detiber

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@prksu prksu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
4 participants
@timoreimann @k8s-ci-robot @xmudrii @prksu