clean up ssh keys when cleaning up e2e test resources #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
thanks @MorrisLaw there is a few issues |
|
Build issues are fixed. Any recommendations/advice on how I can test this? @cpanato |
cpanato
reviewed
Oct 7, 2022
…ight string comparison
cpanato
reviewed
Oct 7, 2022
hack/do-janitor/do-janitor.go
Outdated
| capdoStr := "capdo" // using this for repeated comparisons in the loop below | ||
| for _, key := range keys { | ||
| // we only care to cleanup keys that start with "capdo" | ||
| if len(key.Name) >= len(capdoStr) && key.Name[0:len(capdoStr)] == capdoStr { |
There was a problem hiding this comment.
the ssh keys we generate start with capdo- how about we do a simple check with strings.HasPrefix(key.Name, "capdo-")
There was a problem hiding this comment.
Even better! Will update shortly
cpanato
approved these changes
Oct 18, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, MorrisLaw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cleans up ssh keys from our DO test account whenever do-janitor is called.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #238
Special notes for your reviewer:
Not 100% sure how this will work since I'm not able to compare a
createdAttime value to thetimeToCleanInHoursvalue we'd typically use within do-janitor (godo.Key does not have this as an available field nor does it seem to ever set one implicitly somewhere). It seems like we only run do-janitor when we want to clean up old resources in the DO account. The only problem I can think of is if we want there to be some longstanding ssh keys to exist within the DO account (outside of these ephemeral e2e test keys). Then this code would likely delete them every time do-janitor is ran. But hard to tell for sure unless I can manually test this.Any recommendations for how I can test this change (safely)? @timoreimann @cpanato
Also, is this issue still an issue? Or is it stale at this point. I don't see any left over keys in the account aside from some created by other co-maintainers.
Documentation:
Release note: