Make conversion-gen output location explicit #250
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @stmcginnis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
The conversion-gen command has an --output-base argument to control where generated files are placed. The default value for this argument can vary depending on whether or not $GOPATH is set or not. This results in our generated files being created in the wrong place for some people in a subtle and non-obvious way. For those running `make generate` with GOPATH set, the files are created in `$GOPATH/src/[file path]`. For those without GOPATH set, files are created where we expect them to be within the repo at `./[file path]`. To make sure files are always generated to the location where we expect them to be, this updates our calls to conversion-gen to always be explicit when not within GOPATH by setting `--output-base=[repo_path]`. Signed-off-by: Sean McGinnis <[email protected]>
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
There was a problem hiding this comment.
Hi @stmcginnis thanks for catching this issue.
I'm unable to reproduce this since we don't have any conversion to be generated yet 😅 however we will definitely implement conversion in the future.
thanks!!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prksu, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
The conversion-gen command has an --output-base argument to control
where generated files are placed. The default value for this argument
can vary depending on whether or not $GOPATH is set or not. This results
in our generated files being created in the wrong place for some people
in a subtle and non-obvious way.
For those running
make generatewith GOPATH set, the files are createdin
$GOPATH/src/[file path]. For those without GOPATH set, files arecreated where we expect them to be within the repo at
./[file path].To make sure files are always generated to the location where we expect
them to be, this updates our calls to conversion-gen to always be
explicit when not within GOPATH by setting
--output-base=[repo_path].Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #249
Special notes for your reviewer:
Should be able to reproduce locally to validate by cloning repo outside of GOPATH. Check and remove any remnants found under ls "$(go env GOPATH)/src", then run make generate-go-core. Prior to applying this change, you will see awsclient and others show up under $GOPATH/src, after you will see updates within the repo.
Release note: